path: root/ae/f74f32ee7f140ec32d91f2439d1215c060fd8b

Delivery-date: Fri, 07 Mar 2025 14:25:12 -0800
Received: from mail-yw1-f186.google.com ([209.85.128.186])
	by mail.fairlystable.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <bitcoindev+bncBDRIFMNQZANRBPPEVW7AMGQE4BLAG3A@googlegroups.com>)
	id 1tqg7z-0007pz-3D
	for bitcoindev@gnusha.org; Fri, 07 Mar 2025 14:25:11 -0800
Received: by mail-yw1-f186.google.com with SMTP id 00721157ae682-6feb6604cbfsf27031137b3.3
        for <bitcoindev@gnusha.org>; Fri, 07 Mar 2025 14:25:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=googlegroups.com; s=20230601; t=1741386305; x=1741991105; darn=gnusha.org;
        h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post
         :list-id:mailing-list:precedence:x-original-sender:mime-version
         :subject:references:in-reply-to:message-id:to:from:date:sender:from
         :to:cc:subject:date:message-id:reply-to;
        bh=y9c/jfyNisMG5ilic2QZZnEIXy3Ne+Y9niYQPwFfTfo=;
        b=vKFM1gP1ILejkjjjmiq+bB5LarktBuwyvocUA67WLclWNSYgcYVUlPYspumKRDilvi
         TSjJp8n9uCzom5/JuAgHF9Sah69/BqMzbcgNzXdt90Aqase7DIo8N/HurkvtHlWMKJ/p
         rZQZGOoOAFyp6E0+W2BwWpti5cDlhA6+lp+EksHCDi+wXNzB30GNAzltkiqnMvT6DEv4
         hKoHZWAhJy3PAgB+/hPUg3XG+WZlHSexy/Bu2jCkWXiCorANlLxGG9dkdt3SzYYIyvE3
         h0DAzimy5DMgXW3fVIyGfHU3R4lJ3bJm0J9E27jelRRPTXekMvGmH6GrDuSi8C1QcRki
         RtRw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1741386305; x=1741991105; darn=gnusha.org;
        h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post
         :list-id:mailing-list:precedence:x-original-sender:mime-version
         :subject:references:in-reply-to:message-id:to:from:date:from:to:cc
         :subject:date:message-id:reply-to;
        bh=y9c/jfyNisMG5ilic2QZZnEIXy3Ne+Y9niYQPwFfTfo=;
        b=mug5bA1MlMG29V6R7zWFeJxa/h+BUvI4mk5aPR+W9eiH87LSjtkgnhiKlm010l/lul
         DZ71RXqKGEI+O7r4wjzxqfeGFAPZ6e4hIx+hD7e1m1/qS8KEtOIBSDRrDS0LvJJ5fB4D
         LkTJN9TSMUwCiVAEjkvJ4Uvhd+8K+Bh5GSXymUqKA//DIjDyA1nr9a8k75h7p+JQaUqy
         UWSB/pUyQi5EKaTGSfgPWEIYXui5Ug0kG3R9fDCTM6MjWuQbmRDy9f0ZA3SOubM7DETQ
         xAoUxeth6foaBmcpPcqV+o24amie8mAn3V2/imCbHiG8oIM/h6jKzWk2AHDF3AXW+qN3
         itPg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1741386305; x=1741991105;
        h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post
         :list-id:mailing-list:precedence:x-original-sender:mime-version
         :subject:references:in-reply-to:message-id:to:from:date:x-beenthere
         :x-gm-message-state:sender:from:to:cc:subject:date:message-id
         :reply-to;
        bh=y9c/jfyNisMG5ilic2QZZnEIXy3Ne+Y9niYQPwFfTfo=;
        b=Rxwoe3ywjUpzJKi8viNLqY2ytuA2EQUaabaibe3Gua4G0aguPL3AsYbvHRpdljEsf0
         rw1qn6NdIGBv24sJ24tcfTdLdIeIqUX8OndzvG0OUk1M76fIiopsTHbBb7m5ClAuEJqZ
         eIQ/7NjLOXaUWFB/jsN/mai0GHQ3czVQvkqgOHxLdi+2I/bY2m9/07vL51e25xBQacWQ
         GSlZXcTbld7TVmpHu/mcO0j7syRboONcvbqHB0jDMF9Qw9fp+Rsjvxbbgt8fhiRtFcSL
         aoXw/BUqaviuIf557Dw2R/+1KrEgVOjBLzq1CGXfKWLhwdV7NNjnnfQkwhKtOiAiTBXX
         5TZA==
Sender: bitcoindev@googlegroups.com
X-Forwarded-Encrypted: i=1; AJvYcCURisGSAdGCc4GDpxgpViGVVOPVUsAMr1LnB7U7nQqDsEw2jTPm7whCbAqdeZ7jRt+Lf/NGp9kdxHgt@gnusha.org
X-Gm-Message-State: AOJu0YwtzBFMnXeQSXrS0gnTSL1qNQXn679LeuYCTz7bRtD6iqPmNX+g
	jWkB2cFZZ7Zy1Adswo16GZYms91Vy/52x4KZnbyOxoa0GoN/fnEx
X-Google-Smtp-Source: AGHT+IHF7qTfBhCfAgw8+evlt5JBGBbJNYVD2BcdE1hYjsgIBneHd1wJ+fYyGzf1B7SsFPyp5IZnRg==
X-Received: by 2002:a05:6902:1b13:b0:e5d:b14d:b773 with SMTP id 3f1490d57ef6-e635c14e91emr6898450276.20.1741386305273;
        Fri, 07 Mar 2025 14:25:05 -0800 (PST)
X-BeenThere: bitcoindev@googlegroups.com; h=Adn5yVEc7kb3YotiULXBYnm4RNpUyyG4uUQOOWHcFTEEE8/NQA==
Received: by 2002:a25:5882:0:b0:e60:873d:ae8f with SMTP id 3f1490d57ef6-e63489dcd50ls271689276.2.-pod-prod-09-us;
 Fri, 07 Mar 2025 14:25:01 -0800 (PST)
X-Received: by 2002:a05:690c:6209:b0:6f9:7b99:8a29 with SMTP id 00721157ae682-6febf38dc37mr75923627b3.34.1741386301485;
        Fri, 07 Mar 2025 14:25:01 -0800 (PST)
Received: by 2002:a05:690c:b87:b0:6fb:b341:b6f6 with SMTP id 00721157ae682-6fda2c0e805ms7b3;
        Fri, 7 Mar 2025 13:45:51 -0800 (PST)
X-Received: by 2002:a05:690c:7090:b0:6fd:2fcf:12f5 with SMTP id 00721157ae682-6febf35c835mr75278747b3.27.1741383951043;
        Fri, 07 Mar 2025 13:45:51 -0800 (PST)
Date: Fri, 7 Mar 2025 13:45:50 -0800 (PST)
From: Greg Sanders <gsanders87@gmail.com>
To: Bitcoin Development Mailing List <bitcoindev@googlegroups.com>
Message-Id: <fb040d17-e79f-4442-b906-a6fca7d8970cn@googlegroups.com>
In-Reply-To: <Z770qq4fqF6ldDJ9@petertodd.org>
References: <jiyMlvTX8BnG71f75SqChQZxyhZDQ65kldcugeIDJVJsvK4hadCO3GT46xFc7_cUlWdmOCG0B_WIz0HAO5ZugqYTuX5qxnNLRBn3MopuATI=@protonmail.com>
 <ff82fe21-8e02-42df-8760-c3e358a12766@murch.one>
 <53c78eb9-2050-46d5-a688-be82846135a4n@googlegroups.com>
 <Z6-AD12xTqxCxjqf@petertodd.org>
 <97c36a7a-fe4d-4e24-8bbb-a55b7284fe71n@googlegroups.com>
 <Z770qq4fqF6ldDJ9@petertodd.org>
Subject: Re: [bitcoindev] Update on the Great Consensus Cleanup Revival
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_64604_1852033317.1741383950689"
X-Original-Sender: gsanders87@gmail.com
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com
List-ID: <bitcoindev.googlegroups.com>
X-Google-Group-Id: 786775582512
List-Post: <https://groups.google.com/group/bitcoindev/post>, <mailto:bitcoindev@googlegroups.com>
List-Help: <https://groups.google.com/support/>, <mailto:bitcoindev+help@googlegroups.com>
List-Archive: <https://groups.google.com/group/bitcoindev
List-Subscribe: <https://groups.google.com/group/bitcoindev/subscribe>, <mailto:bitcoindev+subscribe@googlegroups.com>
List-Unsubscribe: <mailto:googlegroups-manage+786775582512+unsubscribe@googlegroups.com>,
 <https://groups.google.com/group/bitcoindev/subscribe>
X-Spam-Score: -0.5 (/)

------=_Part_64604_1852033317.1741383950689
Content-Type: multipart/alternative; 
	boundary="----=_Part_64605_1620459259.1741383950689"

------=_Part_64605_1620459259.1741383950689
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I opened an issue a while ago on this=20
topic: https://github.com/bitcoin/bitcoin/issues/26113

On Wednesday, February 26, 2025 at 7:29:23=E2=80=AFAM UTC-5 Peter Todd wrot=
e:

> On Sat, Feb 15, 2025 at 01:13:24PM -0800, Antoine Riard wrote:
> > Hi Peter,
> >=20
> > I'm talking about this check in VerifyScript as of commit 43e71f74 in=
=20
> > bitcoin core.
> >=20
> > ```
> > if ((flags & SCRIPT_VERIFY_SIGPUSHONLY) !=3D 0 &&=20
> > !scriptSig.IsPushOnly()) {
> > return set_error(serror, SCRIPT_ERR_SIG_PUSHONLY);
> > }
> > ```
> >=20
> > In my understanding, we never set SCRIPT_VERIFY_SIGPUSHONLY, neither in=
=20
> > MANDATORY_SCRIPT_VERIFY_FLAGS,
> > nor in STANDARD_SCRIPT_VERIFY_FLAGS, and this sounds okay as it's a=20
> script=20
> > check pertaining to BIP62
> > rule 2, and BIP62 was never activated. As far as I can tell, that's mor=
e=20
> a=20
> > stale check just right=20
> > there in the interpreter code paths.
>
> Right. So the unused code is just those three lines and the single line
> defining SCRIPT_VERIFY_SIGPUSHONLY in script (plus four lines of test
> code); IsPushOnly() itself *is* used elsewhere in consensus.
>
> You could opena pull-req to remove that if you want. But the tests of
> SCRIPT_VERIFY_SIGPUSHONLY indirectly test IsPushOnly(), so not
> immediately clear if that's actually a good idea.
>
> --=20
> https://petertodd.org 'peter'[:-1]@petertodd.org
>

--=20
You received this message because you are subscribed to the Google Groups "=
Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/bitcoindev/=
fb040d17-e79f-4442-b906-a6fca7d8970cn%40googlegroups.com.

------=_Part_64605_1620459259.1741383950689
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I opened an issue a while ago on this topic:=C2=A0https://github.com/bitcoi=
n/bitcoin/issues/26113<br /><br /><div class=3D"gmail_quote"><div dir=3D"au=
to" class=3D"gmail_attr">On Wednesday, February 26, 2025 at 7:29:23=E2=80=
=AFAM UTC-5 Peter Todd wrote:<br/></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin: 0 0 0 0.8ex; border-left: 1px solid rgb(204, 204, 204); pad=
ding-left: 1ex;">On Sat, Feb 15, 2025 at 01:13:24PM -0800, Antoine Riard wr=
ote:
<br>&gt; Hi Peter,
<br>&gt;=20
<br>&gt; I&#39;m talking about this check in VerifyScript as of commit 43e7=
1f74 in=20
<br>&gt; bitcoin core.
<br>&gt;=20
<br>&gt; ```
<br>&gt;     if ((flags &amp; SCRIPT_VERIFY_SIGPUSHONLY) !=3D 0 &amp;&amp;=
=20
<br>&gt; !scriptSig.IsPushOnly()) {
<br>&gt;         return set_error(serror, SCRIPT_ERR_SIG_PUSHONLY);
<br>&gt;     }
<br>&gt; ```
<br>&gt;=20
<br>&gt; In my understanding, we never set SCRIPT_VERIFY_SIGPUSHONLY, neith=
er in=20
<br>&gt; MANDATORY_SCRIPT_VERIFY_FLAGS,
<br>&gt; nor in STANDARD_SCRIPT_VERIFY_FLAGS, and this sounds okay as it&#3=
9;s a script=20
<br>&gt; check pertaining to BIP62
<br>&gt; rule 2, and BIP62 was never activated. As far as I can tell, that&=
#39;s more a=20
<br>&gt; stale check just right=20
<br>&gt; there in the interpreter code paths.
<br>
<br>Right. So the unused code is just those three lines and the single line
<br>defining SCRIPT_VERIFY_SIGPUSHONLY in script (plus four lines of test
<br>code); IsPushOnly() itself *is* used elsewhere in consensus.
<br>
<br>You could opena pull-req to remove that if you want. But the tests of
<br>SCRIPT_VERIFY_SIGPUSHONLY indirectly test IsPushOnly(), so not
<br>immediately clear if that&#39;s actually a good idea.
<br>
<br>--=20
<br><a href=3D"https://petertodd.org" target=3D"_blank" rel=3D"nofollow" da=
ta-saferedirecturl=3D"https://www.google.com/url?hl=3Den&amp;q=3Dhttps://pe=
tertodd.org&amp;source=3Dgmail&amp;ust=3D1741470238898000&amp;usg=3DAOvVaw0=
eZfaz7E48TWKtl_1j0hPp">https://petertodd.org</a> &#39;peter&#39;[:-1]@<a hr=
ef=3D"http://petertodd.org" target=3D"_blank" rel=3D"nofollow" data-safered=
irecturl=3D"https://www.google.com/url?hl=3Den&amp;q=3Dhttp://petertodd.org=
&amp;source=3Dgmail&amp;ust=3D1741470238898000&amp;usg=3DAOvVaw3b-HwPkWCaE6=
EtUuVTQqXD">petertodd.org</a>
<br></blockquote></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;Bitcoin Development Mailing List&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:bitcoindev+unsubscribe@googlegroups.com">bitcoind=
ev+unsubscribe@googlegroups.com</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
bitcoindev/fb040d17-e79f-4442-b906-a6fca7d8970cn%40googlegroups.com?utm_med=
ium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msgid/bitcoind=
ev/fb040d17-e79f-4442-b906-a6fca7d8970cn%40googlegroups.com</a>.<br />

------=_Part_64605_1620459259.1741383950689--

------=_Part_64604_1852033317.1741383950689--