Delivery-date: Fri, 07 Mar 2025 14:25:12 -0800
Sender: bitcoindev@googlegroups.com
Date: Fri, 7 Mar 2025 13:45:50 -0800 (PST)
From: Greg Sanders <gsanders87@gmail.com>
To: Bitcoin Development Mailing List <bitcoindev@googlegroups.com>
Message-Id: <fb040d17-e79f-4442-b906-a6fca7d8970cn@googlegroups.com>
In-Reply-To: <Z770qq4fqF6ldDJ9@petertodd.org>
References: <jiyMlvTX8BnG71f75SqChQZxyhZDQ65kldcugeIDJVJsvK4hadCO3GT46xFc7_cUlWdmOCG0B_WIz0HAO5ZugqYTuX5qxnNLRBn3MopuATI=@protonmail.com>
 <ff82fe21-8e02-42df-8760-c3e358a12766@murch.one>
 <53c78eb9-2050-46d5-a688-be82846135a4n@googlegroups.com>
 <Z6-AD12xTqxCxjqf@petertodd.org>
 <97c36a7a-fe4d-4e24-8bbb-a55b7284fe71n@googlegroups.com>
 <Z770qq4fqF6ldDJ9@petertodd.org>
Subject: Re: [bitcoindev] Update on the Great Consensus Cleanup Revival
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_64604_1852033317.1741383950689"
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com

------=_Part_64604_1852033317.1741383950689
Content-Type: multipart/alternative; 
	boundary="----=_Part_64605_1620459259.1741383950689"

------=_Part_64605_1620459259.1741383950689
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I opened an issue a while ago on this=20
topic: https://github.com/bitcoin/bitcoin/issues/26113

On Wednesday, February 26, 2025 at 7:29:23=E2=80=AFAM UTC-5 Peter Todd wrot=
e:

> On Sat, Feb 15, 2025 at 01:13:24PM -0800, Antoine Riard wrote:
> > Hi Peter,
> >=20
> > I'm talking about this check in VerifyScript as of commit 43e71f74 in=
=20
> > bitcoin core.
> >=20
> > ```
> > if ((flags & SCRIPT_VERIFY_SIGPUSHONLY) !=3D 0 &&=20
> > !scriptSig.IsPushOnly()) {
> > return set_error(serror, SCRIPT_ERR_SIG_PUSHONLY);
> > }
> > ```
> >=20
> > In my understanding, we never set SCRIPT_VERIFY_SIGPUSHONLY, neither in=
=20
> > MANDATORY_SCRIPT_VERIFY_FLAGS,
> > nor in STANDARD_SCRIPT_VERIFY_FLAGS, and this sounds okay as it's a=20
> script=20
> > check pertaining to BIP62
> > rule 2, and BIP62 was never activated. As far as I can tell, that's mor=
e=20
> a=20
> > stale check just right=20
> > there in the interpreter code paths.
>
> Right. So the unused code is just those three lines and the single line
> defining SCRIPT_VERIFY_SIGPUSHONLY in script (plus four lines of test
> code); IsPushOnly() itself *is* used elsewhere in consensus.
>
> You could opena pull-req to remove that if you want. But the tests of
> SCRIPT_VERIFY_SIGPUSHONLY indirectly test IsPushOnly(), so not
> immediately clear if that's actually a good idea.
>
> --=20
> https://petertodd.org 'peter'[:-1]@petertodd.org
>

--=20
You received this message because you are subscribed to the Google Groups "=
Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/bitcoindev/=
fb040d17-e79f-4442-b906-a6fca7d8970cn%40googlegroups.com.

------=_Part_64605_1620459259.1741383950689
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I opened an issue a while ago on this topic:=C2=A0https://github.com/bitcoi=
n/bitcoin/issues/26113<br /><br /><div class=3D"gmail_quote"><div dir=3D"au=
to" class=3D"gmail_attr">On Wednesday, February 26, 2025 at 7:29:23=E2=80=
=AFAM UTC-5 Peter Todd wrote:<br/></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin: 0 0 0 0.8ex; border-left: 1px solid rgb(204, 204, 204); pad=
ding-left: 1ex;">On Sat, Feb 15, 2025 at 01:13:24PM -0800, Antoine Riard wr=
ote:
<br>&gt; Hi Peter,
<br>&gt;=20
<br>&gt; I&#39;m talking about this check in VerifyScript as of commit 43e7=
1f74 in=20
<br>&gt; bitcoin core.
<br>&gt;=20
<br>&gt; ```
<br>&gt;     if ((flags &amp; SCRIPT_VERIFY_SIGPUSHONLY) !=3D 0 &amp;&amp;=
=20
<br>&gt; !scriptSig.IsPushOnly()) {
<br>&gt;         return set_error(serror, SCRIPT_ERR_SIG_PUSHONLY);
<br>&gt;     }
<br>&gt; ```
<br>&gt;=20
<br>&gt; In my understanding, we never set SCRIPT_VERIFY_SIGPUSHONLY, neith=
er in=20
<br>&gt; MANDATORY_SCRIPT_VERIFY_FLAGS,
<br>&gt; nor in STANDARD_SCRIPT_VERIFY_FLAGS, and this sounds okay as it&#3=
9;s a script=20
<br>&gt; check pertaining to BIP62
<br>&gt; rule 2, and BIP62 was never activated. As far as I can tell, that&=
#39;s more a=20
<br>&gt; stale check just right=20
<br>&gt; there in the interpreter code paths.
<br>
<br>Right. So the unused code is just those three lines and the single line
<br>defining SCRIPT_VERIFY_SIGPUSHONLY in script (plus four lines of test
<br>code); IsPushOnly() itself *is* used elsewhere in consensus.
<br>
<br>You could opena pull-req to remove that if you want. But the tests of
<br>SCRIPT_VERIFY_SIGPUSHONLY indirectly test IsPushOnly(), so not
<br>immediately clear if that&#39;s actually a good idea.
<br>
<br>--=20
<br><a href=3D"https://petertodd.org" target=3D"_blank" rel=3D"nofollow" da=
ta-saferedirecturl=3D"https://www.google.com/url?hl=3Den&amp;q=3Dhttps://pe=
tertodd.org&amp;source=3Dgmail&amp;ust=3D1741470238898000&amp;usg=3DAOvVaw0=
eZfaz7E48TWKtl_1j0hPp">https://petertodd.org</a> &#39;peter&#39;[:-1]@<a hr=
ef=3D"http://petertodd.org" target=3D"_blank" rel=3D"nofollow" data-safered=
irecturl=3D"https://www.google.com/url?hl=3Den&amp;q=3Dhttp://petertodd.org=
&amp;source=3Dgmail&amp;ust=3D1741470238898000&amp;usg=3DAOvVaw3b-HwPkWCaE6=
EtUuVTQqXD">petertodd.org</a>
<br></blockquote></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;Bitcoin Development Mailing List&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:bitcoindev+unsubscribe@googlegroups.com">bitcoind=
ev+unsubscribe@googlegroups.com</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
bitcoindev/fb040d17-e79f-4442-b906-a6fca7d8970cn%40googlegroups.com?utm_med=
ium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msgid/bitcoind=
ev/fb040d17-e79f-4442-b906-a6fca7d8970cn%40googlegroups.com</a>.<br />

------=_Part_64605_1620459259.1741383950689--

------=_Part_64604_1852033317.1741383950689--