1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
|
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
helo=mx.sourceforge.net)
by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <jgarzik@exmulti.com>) id 1Qg3TD-0005FQ-6S
for bitcoin-development@lists.sourceforge.net;
Sun, 10 Jul 2011 23:31:27 +0000
X-ACL-Warn:
Received: from mail-iw0-f175.google.com ([209.85.214.175])
by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1Qg3TB-0000dF-S4
for bitcoin-development@lists.sourceforge.net;
Sun, 10 Jul 2011 23:31:27 +0000
Received: by iwn4 with SMTP id 4so4320698iwn.34
for <bitcoin-development@lists.sourceforge.net>;
Sun, 10 Jul 2011 16:31:20 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.62.83 with SMTP id w19mr4000804ibh.147.1310340680467; Sun,
10 Jul 2011 16:31:20 -0700 (PDT)
Received: by 10.231.35.67 with HTTP; Sun, 10 Jul 2011 16:31:20 -0700 (PDT)
X-Originating-IP: [99.173.148.118]
In-Reply-To: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052>
References: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052>
Date: Sun, 10 Jul 2011 19:31:20 -0400
Message-ID: <CA+8xBpdqrJxP0VLpX3yk+-u6WL_xqy5zXztznKku_h+eGo1aYQ@mail.gmail.com>
From: Jeff Garzik <jgarzik@exmulti.com>
To: Michael Offel <Michael.Offel@web.de>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: 0.1 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
0.1 AWL AWL: From: address is in the auto white-list
X-Headers-End: 1Qg3TB-0000dF-S4
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] overall bitcoin client code quality
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Sun, 10 Jul 2011 23:31:27 -0000
On Sun, Jul 10, 2011 at 6:37 PM, Michael Offel <Michael.Offel@web.de> wrote:
> 1. nearly no code documentation
agreed -- contributions welcome
> 2. isolation of modules
It is a long term goal to move towards 'libbitcoin"
> 3. poor use of threads
agreed -- contributions welcome
> 4. long build times
very low priority.
> 5. style guide
contributions to existing style guide welcome
> 6. hardcoded values
very low priority
> Let me also say that I'm not pointing to someone to do all this. I'm willing to spend a lot of time on this promising project but this kind of cleanup is simply too large for one person who is new to the code.
> My overall suggestion is to begin a complete rewrite, inspired by the old code rather than moving a lot of "known to be somehow functional" around.
> The official Bitcoin client should be some kind of an reference project for other clients and must therefore be extra clean and well documented.
>
> Hopefully I did not hurt someone's feelings.
We know the code isn't what people would prefer, but that's what we've
inherited. Everybody has suggestions, but given limited development
resources we're swamped as is. (hence all the "contributions welcome"
responses)
--
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti.com
|
