1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
|
Delivery-date: Wed, 26 Feb 2025 04:29:30 -0800
Received: from mail-ot1-f61.google.com ([209.85.210.61])
by mail.fairlystable.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
(Exim 4.94.2)
(envelope-from <bitcoindev+bncBDRYHVHZTUGRBIES7S6QMGQEXGQHCNY@googlegroups.com>)
id 1tnGXZ-0006mS-8S
for bitcoindev@gnusha.org; Wed, 26 Feb 2025 04:29:29 -0800
Received: by mail-ot1-f61.google.com with SMTP id 46e09a7af769-724d17262dfsf1814539a34.1
for <bitcoindev@gnusha.org>; Wed, 26 Feb 2025 04:29:29 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1740572963; cv=pass;
d=google.com; s=arc-20240605;
b=c/74oeRx4wXw3eTkxtKYIE8PmcIhh+axfYYMj0vjQ58zzIofbd1Nyu3iDq+qf7vfi3
akjniEY1hwu5Zzud7YT/SV9jQoRcMgBYqQZOOoh6ndjjnnAJ85GwCY1QuM6DeuYiGqb9
xd5Mwf9T7g7lmJ1nyQQ6nhFMo0jXHf0tdrPEIEprXNFO9/PhAOFPWLYRcWtoKaILh8Vh
0ebKRObVricLPXQlnKSjZHsRhbQDP2IkhedlmD0cXOKKDFOIXUhOGdDKiN6PlaNyj3sZ
l4iGZHnCzHJAlWdKewokG1qyp+p89wHsGMjpWekviReG/wzHu1n2XIJ783Ggrw2tqn0c
IzRg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605;
h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post
:list-id:mailing-list:precedence:in-reply-to:content-disposition
:mime-version:references:message-id:subject:cc:to:from:date
:feedback-id:sender:dkim-signature;
bh=es7KR3WKfPiYEEgAW41uVsyE8va2Pc7l1/WlXsb5qcs=;
fh=j0yaVPy9tYm2lTzuU9A/VSnb82h/jFBp6OtAqhoQRi0=;
b=kCbOJmKU0yjJJBQsmUO5tMCGpHfaINEThfwnonVsDT2mjk+PKzZSLF1hq3frnHJLWy
JqK5z1rBz/umAhdhLWPvPMIBa0lgHKE24zTqxJvGIGiEzD9HcwH/itEVvZQy+XkMIrNS
oI8t2xh40pwIQ+7y78GVzhMk3JUEhVStJJzhKnoFB2wdeXWJQire9YFYwvqzUpjuq2m7
xmBVKZC7zd3mP/+J7mp9nH6upPe/9B5La+1tTwzZDTt412wCJnf6qBMG4j3t1PL7fuNt
IZfsbVm2WIpJGW0rolTrrFDaHo8n7mxW6poJ5xp1yAjSYXZOmII0tWVp4Xw93uHkaBCi
sM0A==;
darn=gnusha.org
ARC-Authentication-Results: i=2; gmr-mx.google.com;
dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=oPRFoZod;
spf=pass (google.com: domain of pete@petertodd.org designates 202.12.124.141 as permitted sender) smtp.mailfrom=pete@petertodd.org
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=googlegroups.com; s=20230601; t=1740572963; x=1741177763; darn=gnusha.org;
h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post
:list-id:mailing-list:precedence:x-original-authentication-results
:x-original-sender:in-reply-to:content-disposition:mime-version
:references:message-id:subject:cc:to:from:date:feedback-id:sender
:from:to:cc:subject:date:message-id:reply-to;
bh=es7KR3WKfPiYEEgAW41uVsyE8va2Pc7l1/WlXsb5qcs=;
b=bnmimPYRL4dHm1+S8rmxyj9EvZHrfFSRu+vDIDkcSEcBF0tYfk/ynWu3kBCDwQI8rX
/aLuRq7WWpCeQLDxNs5VNgSOpdcuVnXQ0zCNVImlnSDCDBjv8rambmPr2um7wshis1/y
Yg/fr12fpzu36xfR16lDCbavB60xX5isp8XmO/bQCGpWzSwfF6F57g0v8Bgc4DqBU7km
dL28k8++4tJq0kw04zd2xeQnfmdIIbalZjTGIwbdZAs0sEZ2fn6ds3xoEwtGNHa0cPPJ
yOt1iTLynw+DMojz99sGNYk/62BD8hiMhP6fCl+8pIIfZBxjxt2PsKi/5l7vykrgo0K/
Y5ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1740572963; x=1741177763;
h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post
:list-id:mailing-list:precedence:x-original-authentication-results
:x-original-sender:in-reply-to:content-disposition:mime-version
:references:message-id:subject:cc:to:from:date:feedback-id
:x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date
:message-id:reply-to;
bh=es7KR3WKfPiYEEgAW41uVsyE8va2Pc7l1/WlXsb5qcs=;
b=ktiBDoqWtTCHoROlsVAqNQHyAb1JVhYUrCs9Jl3/gBVGVHD3/LlxW929Z2wzmGigK+
awQ27BTyK0W1aH2Z0kLB85knk2mWJmk9UkhBBNBO4S05NA17FizftRXDVFPsyB3TqDsZ
0Q3oe1m2HnoIbBe0nRHxYa2RltaB/6CwEckhldCFnqTvaPHDHdv8HlxmaPneuCyuE1gD
AlgwEfsHn5V7tnaSufKwqZXQJEtIxxXvxtkDSDFjtYD4tOnAs3vrofRSNJDn8NPCs5dL
ZOZVei8DOTzOc54/nEw+E26LRGX/DXkvm72xHIh0gZKA8nAIikU7T+dbcEnuYffdDhUS
DXfg==
Sender: bitcoindev@googlegroups.com
X-Forwarded-Encrypted: i=2; AJvYcCUep0YEDLJoyZAtJ5CbsliLIdWBv184Fy7CsiIdxAORjxPPQ7wJaTMXgyPucfpAYlj54REx184K1vEM@gnusha.org
X-Gm-Message-State: AOJu0YwZakttCYQaYsRF8q757hSjOVsPiFn8XjbEBf8zT0I9pM29d22r
LDISajdbBBkmSbHs3ogfEIRRosTmwHjDcjzjGlgvz2N0QquG3yqx
X-Google-Smtp-Source: AGHT+IFdwOmffJLo3pYdPVCp1JY1RAdf0Bo1QRkxiOZ/0dfZARomoB+1tLdfTn2eCpOD/5vQO2JJkQ==
X-Received: by 2002:a05:6830:6d17:b0:727:423c:95d5 with SMTP id 46e09a7af769-7289d0ef042mr4236326a34.3.1740572963493;
Wed, 26 Feb 2025 04:29:23 -0800 (PST)
X-BeenThere: bitcoindev@googlegroups.com; h=Adn5yVEodAcMHJQ5RzIIg0vQ9/fbQE9EXDFzEr8xwG3JBazHOg==
Received: by 2002:a05:6870:4f0e:b0:2bc:69a2:c157 with SMTP id
586e51a60fabf-2c10fdfdd2els732500fac.0.-pod-prod-06-us; Wed, 26 Feb 2025
04:29:20 -0800 (PST)
X-Received: by 2002:a05:6808:2f11:b0:3eb:4f4d:c292 with SMTP id 5614622812f47-3f540ee6556mr4059115b6e.18.1740572960411;
Wed, 26 Feb 2025 04:29:20 -0800 (PST)
Received: by 2002:aca:1a06:0:b0:3f4:4b9:4605 with SMTP id 5614622812f47-3f42488b059msb6e;
Wed, 26 Feb 2025 03:02:06 -0800 (PST)
X-Received: by 2002:a05:6808:2f1b:b0:3f4:eee:1d34 with SMTP id 5614622812f47-3f540f6c479mr4510674b6e.31.1740567725818;
Wed, 26 Feb 2025 03:02:05 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1740567725; cv=none;
d=google.com; s=arc-20240605;
b=Nw3kZN5iC604NjTtyov3sn14JuqGyZMORXIpdRSyEGZPtBxPivPO0Uiv3rp1ymGJ2W
ujOea11ySpe/86WCpQp7unJDql1FkPt+Z0Mw9eEJQxqq+pQZacYm7MBwZQosx4czcU6W
0QJmhm22iaW5X79rO2vvd5ti4KAQRmIjgfF8S7G1FG1gJw587ytCyTA5POMMhSd1L0xv
bhQH4WVSIH5rxqg0yAPNjzHd1pVBliTvb7dJwYBImnVLiMum3MoxqrY1Is3dRlrsGA2J
A9odriCozEESqyioKDZ2b6PenPRx3hCy9R2mICYBItMREK8MiFnoIkLZrexa7eHh+aRT
ApIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605;
h=in-reply-to:content-disposition:mime-version:references:message-id
:subject:cc:to:from:date:feedback-id:dkim-signature;
bh=5sFmlxPzIodKLFVohBGleWoR9Gw94wRtbyUKt+VY5+g=;
fh=sapDHqhE46zLmMBeB1lkoe0zq8J9+V3Afx71/j8kvug=;
b=lRpeLfUzigectFFG0efiyLGWTMy98gmXiOLB1ceX5zPWlQG84St9HHEFUMYXk5Q3kR
uaJ4bhSn9B6f75ky27+bGwujEBE4/xAMnkYEIY638Cd/tj/uxsbpbNMw4ZXkLhflZo20
LGZTMXxVFnTZln0Z173NzzFK90wEdHCfqS+Ub3RvS5XF63McSHqx4ZvLMB72TW+QSIH3
byCE4V/8RUAjzOs8UyAVjGZwA9SkCKq+sbbXBfO64G9l9HYE+NgxEPsaHq/Ybuf6X714
uezAm8SV4l6+mBgAsLf3p4Uh0tuJRHOJaS3N+udmNRfdhmfZpZgBlqndL8wRqWxbfG57
gBDg==;
dara=google.com
ARC-Authentication-Results: i=1; gmr-mx.google.com;
dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=oPRFoZod;
spf=pass (google.com: domain of pete@petertodd.org designates 202.12.124.141 as permitted sender) smtp.mailfrom=pete@petertodd.org
Received: from flow-b6-smtp.messagingengine.com (flow-b6-smtp.messagingengine.com. [202.12.124.141])
by gmr-mx.google.com with ESMTPS id 5614622812f47-3f541c2962fsi166224b6e.3.2025.02.26.03.02.04
for <bitcoindev@googlegroups.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 26 Feb 2025 03:02:04 -0800 (PST)
Received-SPF: pass (google.com: domain of pete@petertodd.org designates 202.12.124.141 as permitted sender) client-ip=202.12.124.141;
Received: from phl-compute-13.internal (phl-compute-13.phl.internal [10.202.2.53])
by mailflow.stl.internal (Postfix) with ESMTP id 50E531D41020;
Wed, 26 Feb 2025 06:02:04 -0500 (EST)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-13.internal (MEProxy); Wed, 26 Feb 2025 06:02:04 -0500
X-ME-Sender: <xms:rPS-Z7LVaqDGeFFGFSUBwKkwA8lRo9OPqIp1W3dX-AnCM20Kl1Hoow>
<xme:rPS-Z_IEie2F9LA8FGar54MKQIQFi_zI44MSRta21id93YaqSiNoRZ1UAA1wPvinf
EI-FG-MEQW6y0B07CE>
X-ME-Received: <xmr:rPS-ZzvfQKAIWQrwdJL-7lFd_gy1__z2v4Lxw3orAM6YWm-BzQlMI484>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekgeegudcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp
uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv
necuhfhrohhmpefrvghtvghrucfvohguugcuoehpvghtvgesphgvthgvrhhtohguugdroh
hrgheqnecuggftrfgrthhtvghrnhepledvleelffdtudekudffjefgfeejueehieelfedt
gfetudetgeegveeutefhjedtnecuffhomhgrihhnpehpvghtvghrthhouggurdhorhhgne
cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgv
sehpvghtvghrthhouggurdhorhhgpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmth
hpohhuthdprhgtphhtthhopegrnhhtohhinhgvrdhrihgrrhgusehgmhgrihhlrdgtohhm
pdhrtghpthhtohepsghithgtohhinhguvghvsehgohhoghhlvghgrhhouhhpshdrtghomh
X-ME-Proxy: <xmx:rPS-Z0Z6db0iv-Dewk_b8ZXnZLKNlS25wGq8u2U4MG-ldwKbCUFf3g>
<xmx:rPS-Zya4q9-Hnw9ENhBfiKaiXej2rW9ssrmFPsICkJHiSQEJ-RFGHQ>
<xmx:rPS-Z4Aofrv1ka8Ms_C7pVN8ceOD2OCtH2ZJZXKnFV7xjRBMEjs0UA>
<xmx:rPS-ZwbQt_XYek4Pp0MyohNsY8Mdsb3lEx6M5Civ92BLYXSswC-zpA>
<xmx:rPS-Zw0kei0eWdEjwyTWqP1gERPIRHYhrc-OtuEop_cRRknYG6DvdDnP>
Feedback-ID: i525146e8:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
26 Feb 2025 06:02:03 -0500 (EST)
Received: by localhost (Postfix, from userid 1000)
id 8B9B49FCCE; Wed, 26 Feb 2025 11:02:02 +0000 (UTC)
Date: Wed, 26 Feb 2025 11:02:02 +0000
From: Peter Todd <pete@petertodd.org>
To: Antoine Riard <antoine.riard@gmail.com>
Cc: Bitcoin Development Mailing List <bitcoindev@googlegroups.com>
Subject: Re: [bitcoindev] Update on the Great Consensus Cleanup Revival
Message-ID: <Z770qq4fqF6ldDJ9@petertodd.org>
References: <jiyMlvTX8BnG71f75SqChQZxyhZDQ65kldcugeIDJVJsvK4hadCO3GT46xFc7_cUlWdmOCG0B_WIz0HAO5ZugqYTuX5qxnNLRBn3MopuATI=@protonmail.com>
<ff82fe21-8e02-42df-8760-c3e358a12766@murch.one>
<53c78eb9-2050-46d5-a688-be82846135a4n@googlegroups.com>
<Z6-AD12xTqxCxjqf@petertodd.org>
<97c36a7a-fe4d-4e24-8bbb-a55b7284fe71n@googlegroups.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
protocol="application/pgp-signature"; boundary="KukJoydCmuAGBOV8"
Content-Disposition: inline
In-Reply-To: <97c36a7a-fe4d-4e24-8bbb-a55b7284fe71n@googlegroups.com>
X-Original-Sender: pete@petertodd.org
X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass
header.i=@messagingengine.com header.s=fm1 header.b=oPRFoZod; spf=pass
(google.com: domain of pete@petertodd.org designates 202.12.124.141 as
permitted sender) smtp.mailfrom=pete@petertodd.org
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com
List-ID: <bitcoindev.googlegroups.com>
X-Google-Group-Id: 786775582512
List-Post: <https://groups.google.com/group/bitcoindev/post>, <mailto:bitcoindev@googlegroups.com>
List-Help: <https://groups.google.com/support/>, <mailto:bitcoindev+help@googlegroups.com>
List-Archive: <https://groups.google.com/group/bitcoindev
List-Subscribe: <https://groups.google.com/group/bitcoindev/subscribe>, <mailto:bitcoindev+subscribe@googlegroups.com>
List-Unsubscribe: <mailto:googlegroups-manage+786775582512+unsubscribe@googlegroups.com>,
<https://groups.google.com/group/bitcoindev/subscribe>
X-Spam-Score: -0.8 (/)
--KukJoydCmuAGBOV8
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
On Sat, Feb 15, 2025 at 01:13:24PM -0800, Antoine Riard wrote:
> Hi Peter,
>
> I'm talking about this check in VerifyScript as of commit 43e71f74 in
> bitcoin core.
>
> ```
> if ((flags & SCRIPT_VERIFY_SIGPUSHONLY) != 0 &&
> !scriptSig.IsPushOnly()) {
> return set_error(serror, SCRIPT_ERR_SIG_PUSHONLY);
> }
> ```
>
> In my understanding, we never set SCRIPT_VERIFY_SIGPUSHONLY, neither in
> MANDATORY_SCRIPT_VERIFY_FLAGS,
> nor in STANDARD_SCRIPT_VERIFY_FLAGS, and this sounds okay as it's a script
> check pertaining to BIP62
> rule 2, and BIP62 was never activated. As far as I can tell, that's more a
> stale check just right
> there in the interpreter code paths.
Right. So the unused code is just those three lines and the single line
defining SCRIPT_VERIFY_SIGPUSHONLY in script (plus four lines of test
code); IsPushOnly() itself *is* used elsewhere in consensus.
You could opena pull-req to remove that if you want. But the tests of
SCRIPT_VERIFY_SIGPUSHONLY indirectly test IsPushOnly(), so not
immediately clear if that's actually a good idea.
--
https://petertodd.org 'peter'[:-1]@petertodd.org
--
You received this message because you are subscribed to the Google Groups "Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/bitcoindev/Z770qq4fqF6ldDJ9%40petertodd.org.
--KukJoydCmuAGBOV8
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE0RcYcKRzsEwFZ3N5Lly11TVRLzcFAme+9KgACgkQLly11TVR
LzeUEQ/9GL4mCjD6+C/QPLfhft1OXmG+6R1UApRQv86lU+d6v2ThvrAZ76qzC8jT
5YbHUeTE7EmufOqPRj4UtZQlnicu2+g5O83hy5kVRu4XZKRzQTp9BDpoD+KvmukE
hUfoJ/PbeTf8hMq9+1m+9FERUwZ5bzik6sgrK5hQluSgKNTnCSfAZOgmo5ouEQc2
NLVeS4VjjtmPFBrGrkPIucmeUcN0dhWaPQb+jI0jJ98TSjGd06OuBaY73CpB2lPK
q8wIzBJ7GdaMD+WvO6e3vB4D+Jj9iQCY2In3jhNwGROSbwwTD02id/Q4ysOExkzx
zTvCwQaaaoIpUdqSW8bcWfu9A3d3hXgCU3bWgx8fF+D53VupsUp8KKGUyEPV2XhM
Vv2prabEQj5vaxdXvyGakeYqnj9sOwbMy+TU4TYQWLBvIzIuCsio3pBJnbt7Hnto
SsG30uD7NIZLGwc35zZqOxEeBG/Mzqdn0IQbiQG/8GvY9fUMjyYBo17VNu6o3uTd
DNwA2TOXaCA0nwWuPxzY7tMJNYTpiKs0CK8IANB4ev5LgBREc8lF7yFywJ2wCgSZ
wuUHbrrWVGrGHMxXdlqNCCVLKZWHL5N8lLPIFvIEs23I6ZP2fiZitZZImBUAsPXP
EwDEgxyr5mV3mYUpoo2S6wISg7o/cQXKWv0XGpNHiBklmDgZDa0=
=kKr/
-----END PGP SIGNATURE-----
--KukJoydCmuAGBOV8--
|
