1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
|
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
helo=mx.sourceforge.net)
by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <arto@bendiken.net>) id 1VS4Vh-0005vY-8D
for bitcoin-development@lists.sourceforge.net;
Fri, 04 Oct 2013 12:29:33 +0000
Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of bendiken.net
designates 74.125.82.41 as permitted sender)
client-ip=74.125.82.41; envelope-from=arto@bendiken.net;
helo=mail-wg0-f41.google.com;
Received: from mail-wg0-f41.google.com ([74.125.82.41])
by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1VS4Vf-0000nr-Ie
for bitcoin-development@lists.sourceforge.net;
Fri, 04 Oct 2013 12:29:33 +0000
Received: by mail-wg0-f41.google.com with SMTP id l18so2059890wgh.4
for <bitcoin-development@lists.sourceforge.net>;
Fri, 04 Oct 2013 05:29:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc:content-type;
bh=/LtGJ5oJhuVoyPxvWi2+XyLzc7MZgUhoFvckCDs5Qv4=;
b=kLmvwWTq++jHIakpAmfcNNASV8ttmkw156QJJuo5oLuD32uzqkyyeucS3tlFBn6tqb
YFbkz0unCZ55klUbht1WoDWsUWayniXDNNXJhMSnOPqy3AXR2QNOUyTURIuVv+nHsKJc
c4bE3QL96YKyc3p5PzJ2/NRoymuo5LsBrYs+2diEKCRwlREZisErBidwaqlYj1YBOr03
B88efgFLIX1jDFl5To8OfhW3HpWjaHH09rYOaBkUiJWJm8m3lHatUDmXLnOc+rNGYb5m
7plMkPJZFsQd20vy7epz1OODO8zh6IIgyyoab1EvlxqFJFFSR7i+szw3pK3M4kqxmrNk
1XcA==
X-Gm-Message-State: ALoCoQl4scNUGEzhQnEMad66weofRJiRWYa0abq3pYRQStmrxNhIqsaPSDvUNJTwkYB8waBMQjhD
X-Received: by 10.180.20.177 with SMTP id o17mr6963862wie.38.1380887971914;
Fri, 04 Oct 2013 04:59:31 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.217.53.5 with HTTP; Fri, 4 Oct 2013 04:58:51 -0700 (PDT)
X-Originating-IP: [213.239.192.202]
In-Reply-To: <20131004113517.GA8373@savin>
References: <CANEZrP1Sd8cK2YUr4OSvnOxEJrbWpmfdpor-qbap1f98tGqPwg@mail.gmail.com>
<3552695.aET6a1zFq8@momentum> <20131004113517.GA8373@savin>
From: Arto Bendiken <arto@bendiken.net>
Date: Fri, 4 Oct 2013 13:58:51 +0200
Message-ID: <CAE7aNuS00t97g8K-sPJv4Xt+zWbWbDEjfkza8oBq4c5RjfRP1Q@mail.gmail.com>
To: Peter Todd <pete@petertodd.org>
Content-Type: text/plain; charset=UTF-8
X-Spam-Score: -1.5 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information. [URIs: lwn.net]
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
-0.0 SPF_PASS SPF: sender matches SPF record
X-Headers-End: 1VS4Vf-0000nr-Ie
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] Code review
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2013 12:29:33 -0000
On Fri, Oct 4, 2013 at 1:35 PM, Peter Todd <pete@petertodd.org> wrote:
> The second caveat is more specific to Bitcoin: people tend to rebase
> their pull-requests over and over again until they are accepted, but
> that also means that code review done earlier doesn't apply to the later
> code pushed. Bitcoin is a particularly high profile, and high profit,
> target for people trying to get malicious code into the codebase.
On that note, this 2003 example of an attempt to backdoor the Linux
kernel is pertinent:
http://lwn.net/Articles/57135/
The backdoor in question came down to a single missing character,
easily overlooked by a reviewer if a spotlight hadn't been thrown on
it for other reasons. Compromising a Bitcoin implementation isn't
going to be as easy as that, one would hope, but certainly it seems
only a matter of time until there's an attempt at it.
Following these code review discussions with much interest.
--
Arto Bendiken | @bendiken | http://ar.to/
|
