1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
Return-Path: <jl2012@xbt.hk>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id 8E819483
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 1 Sep 2016 11:29:38 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from erelay3.ox.registrar-servers.com
(erelay3.ox.registrar-servers.com [192.64.117.2])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 46D5B139
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 1 Sep 2016 11:29:35 +0000 (UTC)
Received: from localhost (unknown [127.0.0.1])
by erelay1.ox.registrar-servers.com (Postfix) with ESMTP id
60ACA2207E0A; Thu, 1 Sep 2016 11:29:32 +0000 (UTC)
Received: from erelay1.ox.registrar-servers.com ([127.0.0.1])
by localhost (erelay.ox.registrar-servers.com [127.0.0.1]) (amavisd-new,
port 10024)
with LMTP id cLgkTYEFsoW6; Thu, 1 Sep 2016 07:29:29 -0400 (EDT)
Received: from MTA-07.privateemail.com (unknown [10.20.150.170])
(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by erelay1.ox.registrar-servers.com (Postfix) with ESMTPS id
C52D22207DA3; Thu, 1 Sep 2016 07:29:29 -0400 (EDT)
Received: from APP-06 (unknown [10.20.147.156])
(using TLSv1 with cipher AES256-SHA (256/256 bits))
(No client certificate requested)
by MTA-07.privateemail.com (Postfix) with ESMTPSA id 828E160032;
Thu, 1 Sep 2016 11:29:29 +0000 (UTC)
Date: Thu, 1 Sep 2016 07:29:29 -0400 (EDT)
From: Johnson Lau <jl2012@xbt.hk>
Reply-To: Johnson Lau <jl2012@xbt.hk>
To: Sergio Demian Lerner <sergio.d.lerner@gmail.com>
Message-ID: <1348417205.55392.1472729369522@privateemail.com>
In-Reply-To: <CAKzdR-oMEe6rcusn5kajZHvWXEkneywsNEJpooss76o9WuhDxg@mail.gmail.com>
References: <CAKzdR-q4hagujzWxJxmwpxJUQFLe7SKukbDNs=_S_VKgJ9N_TA@mail.gmail.com>
<339348690.148734.1472089774841@privateemail.com>
<CAKzdR-oMEe6rcusn5kajZHvWXEkneywsNEJpooss76o9WuhDxg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="----=_Part_55391_974684541.1472729369462"
X-Priority: 3
Importance: Medium
X-Mailer: Open-Xchange Mailer v7.8.1-Rev19
X-Originating-Client: open-xchange-appsuite
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE,
RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Attack by modifying non-segwit transactions after
segwit is accepted ?
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Sep 2016 11:29:38 -0000
------=_Part_55391_974684541.1472729369462
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Thank you so much for taking time to actually review the codes. I hope you will keep raising questions when you feel something might be wrong. This is how things supposed to work and we should not be affected by some forum discussions.
> On August 26, 2016 at 9:16 AM Sergio Demian Lerner <sergio.d.lerner@gmail.com> wrote:
>
> Because there was a discussion on reddit about this topic, I want to clarify that Johnson Lau explained how a check in the code prevents this attack.
> So there is no real attack.
>
> Also note that the subject of this thread has a question mark, which means that I'm asking the community for clarification, not asserting the existence of a vulnerability.
>
> The segwit code is complex, and some key parts of the consensus code are spread over the source files (such as state.CorruptionPossible() relation to DoS banning, IsNull() check in witness program serialization, etc.).
>
> Thanks again Johnson for your clarifications.
>
>
> On Wed, Aug 24, 2016 at 10:49 PM, Johnson Lau <jl2012@xbt.hk mailto:jl2012@xbt.hk > wrote:
>
> > >
> > Adding witness data to a non-segwit script is invalid by consensus:
> >
> > https://github.com/bitcoin/bitcoin/blob/d612837814020ae832499d18e6ee5eb919a87907/src/script/interpreter.cpp#L1467 https://github.com/bitcoin/bitcoin/blob/d612837814020ae832499d18e6ee5eb919a87907/src/script/interpreter.cpp#L1467
> >
> >
> > This PR will detect such violation early and ban the peer:
> >
> > https://github.com/bitcoin/bitcoin/pull/8499 https://github.com/bitcoin/bitcoin/pull/8499
> >
> >
> >
> >
> > Another approach is to run the scripts of all incoming transactions. That's not too bad as you have already fetched the utxos which is a major part of validation.
> >
> > >
>
------=_Part_55391_974684541.1472729369462
MIME-Version: 1.0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html>
<html><head>
<meta charset=3D"UTF-8">
</head><body><p>Thank you so much for taking time to actually review the co=
des. I hope you will keep raising questions when you feel something mi=
ght be wrong. This is how things supposed to work and we should not be=
affected by some forum discussions.</p><blockquote type=3D"cite">On August=
26, 2016 at 9:16 AM Sergio Demian Lerner <sergio.d.lerner@gmail.com=
2; wrote:<br><br><div dir=3D"ltr"><div>Because there was a discussion on re=
ddit about this topic, I want to clarify that Johnson Lau explained how a c=
heck in the code prevents this attack.<br></div><div>So there is no real at=
tack.<br></div><div><br></div><div>Also note that the subject of this threa=
d has a question mark, which means that I'm asking the community for cl=
arification, not asserting the existence of a vulnerability.<br><br></div><=
div>The segwit code is complex, and some key parts of the consensus code ar=
e spread over the source files (such as state.CorruptionPossible() relation=
to DoS banning, IsNull() check in witness program serialization, etc.). <b=
r><br></div><div>Thanks again Johnson for your clarifications.<br></div><di=
v><br></div></div><div class=3D"ox-455267db53-gmail_extra"><br><div class=
=3D"ox-455267db53-gmail_quote">On Wed, Aug 24, 2016 at 10:49 PM, Johnson La=
u <<a href=3D"mailto:jl2012@xbt.hk" target=3D"_blank">jl2012@xbt.hk</a>=
> wrote:<br><blockquote><u></u><div><p>Adding witness data to a non-seg=
wit script is invalid by consensus:</p><p><a href=3D"https://github.com/bit=
coin/bitcoin/blob/d612837814020ae832499d18e6ee5eb919a87907/src/script/inter=
preter.cpp#L1467" target=3D"_blank">https://github.com/bitcoin/<wbr/>bitcoi=
n/blob/<wbr/>d612837814020ae832499d18e6ee5e<wbr/>b919a87907/src/script/<wbr=
/>interpreter.cpp#L1467</a></p><p><br></p><p>This PR will detect such viola=
tion early and ban the peer:</p><p><a href=3D"https://github.com/bitcoin/bi=
tcoin/pull/8499" target=3D"_blank">https://github.com/bitcoin/<wbr/>bitcoin=
/pull/8499</a></p><p> <br></p><p><br></p><p>Another approach is to run=
the scripts of all incoming transactions. That's not too bad as you ha=
ve already fetched the utxos which is a major part of validation.</p><=
/div></blockquote></div><br></div></blockquote></body></html>
=20
------=_Part_55391_974684541.1472729369462--
|
