1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
|
Return-Path: <freedom@reardencode.com>
Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])
by lists.linuxfoundation.org (Postfix) with ESMTP id D2368C0032
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 22 Aug 2023 20:23:48 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by smtp2.osuosl.org (Postfix) with ESMTP id A703B403AC
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 22 Aug 2023 20:23:48 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A703B403AC
Authentication-Results: smtp2.osuosl.org;
dkim=pass (1024-bit key) header.d=reardencode.com header.i=@reardencode.com
header.a=rsa-sha256 header.s=mail header.b=fp1H6J00
X-Virus-Scanned: amavisd-new at osuosl.org
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from smtp2.osuosl.org ([127.0.0.1])
by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id BTXN3OXuAA_S
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 22 Aug 2023 20:23:47 +0000 (UTC)
Received: from mail.reardencode.com (mail.reardencode.com [206.125.169.165])
by smtp2.osuosl.org (Postfix) with ESMTPS id 09E7D400D2
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 22 Aug 2023 20:23:46 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 09E7D400D2
Date: Tue, 22 Aug 2023 13:23:09 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=reardencode.com;
s=mail; t=1692735822;
bh=HJvv7Qaio2dnOsiqOeLKX6dViCEYk588moNclhJsYqA=;
h=Date:From:To:Cc:Subject:References:In-Reply-To;
b=fp1H6J00iOzgNwzjOYZX+vbw0HaEI2GGnLo9GFfyaoiGgj+DFPtG7Fyg9M8iVfQt0
QG1ojp+rVE+PQIdKK/b38nCZWbTgWh4M0deSC7Dr/Bas24mmQMOZqqIsf9rtWp9C1S
WDdLgUIFMyL772mtjERtuI0hkC5POJmoZNl38ZkY=
From: Brandon Black <freedom@reardencode.com>
To: Greg Sanders <gsanders87@gmail.com>
Message-ID: <ZOUZLdQUdJetkPaR@console>
Mail-Followup-To: Greg Sanders <gsanders87@gmail.com>,
Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
References: <ZOTqppwATA9HyfND@console>
<CAB3F3Dvhp-Zznd0USWW=sWh7AFL4OV3KneWTgdqZu5Z1BYYJKg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB3F3Dvhp-Zznd0USWW=sWh7AFL4OV3KneWTgdqZu5Z1BYYJKg@mail.gmail.com>
X-Operating-System: Linux 5.15.110 x86_64
X-Mailman-Approved-At: Wed, 23 Aug 2023 18:17:09 +0000
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Combined CTV+APO to minimal TXHASH+CSFS
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2023 20:23:48 -0000
> > * If the top item on the stack is not a minimally encoded `OP_0`, `OP_1`,
> or
> `OP_2`; succeed immediately[^2].
>
> I presume this was supposed to go to OP_4 now.
Fixed, thanks!
> > ### How does the efficiency compare to [bip118][]?
>
> Just noting BIP118 also allows pubkey of "1" to stand in for the taproot
> inner pubkey, which would be a common use-case. "simply" adding an opcode
> ala OP_INNER_PUBKEY could also have the same effect of course.
Updated the spec for OP_CSFS to replace OP_0 as pubkey with the taproot
internal key. That's a great feature to keep!
> Also, BIP118 also opens the door for non-APO signatures to have a sighash
> digest that commits to additional data, closing a couple of taproot
> malleability bugs. See
> https://github.com/bitcoin-inquisition/bitcoin/issues/19 for more
> discussion along those lines. These aren't make or break, but would be nice
> to clean up if possible
Agreed. If this proposal moves forward, I will carefully consider the
contents of the hash (as shown in the table at the end) for each mode,
and add (or remove) committed data. It might be worth having mode 0
(CTVish) commit to the spend_type and annex as well.
Thanks much,
--Brandon
|
