1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
|
Return-Path: <eric@voskuil.org>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id C16C5125C
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 15 Mar 2018 09:17:26 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-ot0-f169.google.com (mail-ot0-f169.google.com
[74.125.82.169])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 217EC356
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 15 Mar 2018 09:17:26 +0000 (UTC)
Received: by mail-ot0-f169.google.com with SMTP id l12-v6so6156059otj.7
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 15 Mar 2018 02:17:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=voskuil-org.20150623.gappssmtp.com; s=20150623;
h=from:content-transfer-encoding:mime-version:date:subject:message-id
:references:in-reply-to:to;
bh=ebW7e1/xudiUAJxUwp53jLtWCnp7KDR5pDlcH3GKEmE=;
b=TQqWa9Eedvg+6bsEYOIjhvVyA4x5Qg+OVacQMhD92ePaecgwdioRVCRYrtqqBwXWK7
oIzDG1E/r15RYkLZ/PXFAE+bMG0QiGLtNK+2ttBI2SYAuxe37ul99IWce9SCFo8qWCxG
Q9A7/RwbOGxI0/qIAnwKeZMgjav7JTLSXFldPOPGY8DZKzlksW5o9O01QMgjO9UQmONS
rVSXm6LNdtPKACD0DI2G9NAFTpijvtXgUidBgAAjGvAqRMBcgQUCaGlEfErwtLqEoJib
MGGk9GN+MmX8ZPQt7rO1H6VO42Wk2+gUO52iXQnG56rR5TVR8PP2L8l8LuTgVlDrAQQK
IHtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:content-transfer-encoding:mime-version:date
:subject:message-id:references:in-reply-to:to;
bh=ebW7e1/xudiUAJxUwp53jLtWCnp7KDR5pDlcH3GKEmE=;
b=Z0eAbD/WzJJS0PExs5yxLnwxnC0KQPtCk0/6Z7EF6iFJgu1hwKV0tgWaSGd1o62pu/
3aQ7iAPMHyYNadD6m4688+Wi2ssHCaWNc1TYI8tIE+xd8V3m7c1jOa9AA49T+R8BufcL
vnZIKAPjaLq2HFxPjbUMsHFniVWOJfMhztt+4lylixR4Uhd3fTcB4oj7D8JdgclpymZD
jI1tUVHXL94ocYNebp3ol+IQkt1EGo++5kDlqTxbifPEm+If9iYQ7Ob1yRIuCZohE8Av
RD/AKq4J+5HQWiLFOdCf3lV6NPoguMRbVjasTxTk8r0IBqxoUN/RGlMuHpoDWjELtRMz
cNKw==
X-Gm-Message-State: AElRT7HBI9rYi+A0Qq7MwUrdPaWtiDclqH8i2xjSbHD5WjKJZa1ikeRI
WUOtcQm+fnxVwFRLT7gpDue9yoWuL50=
X-Google-Smtp-Source: AG47ELtKz1AFEudJVLP1p5sIDAWCxKUjK7ePc/roZeRTuqBBHDXIpA/yjDofABMpOrw5V2aGX1rc9w==
X-Received: by 10.157.64.11 with SMTP id m11mr5231189ote.185.1521105445371;
Thu, 15 Mar 2018 02:17:25 -0700 (PDT)
Received: from [10.221.57.40] (mobile-107-107-184-3.mycingular.net.
[107.107.184.3])
by smtp.gmail.com with ESMTPSA id q8sm2507184oig.30.2018.03.15.02.17.24
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 15 Mar 2018 02:17:24 -0700 (PDT)
From: Eric Voskuil <eric@voskuil.org>
Content-Type: multipart/alternative;
boundary=Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Date: Thu, 15 Mar 2018 10:17:22 +0100
Message-Id: <8C660724-A76D-44C1-9140-AD3215768CE1@voskuil.org>
References: <e2fd3226-91ff-d0ca-67c7-2c4a98c6628f@voskuil.org>
<620d4b5e-61c4-4501-9787-c73109908418@achow101.com>
In-Reply-To: <620d4b5e-61c4-4501-9787-c73109908418@achow101.com>
To: Andrew Chow <achow101-lists@achow101.com>,
Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
X-Mailer: iPhone Mail (15D100)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID, HTML_MESSAGE, MIME_QP_LONG_LINE,
RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
X-Mailman-Approved-At: Thu, 15 Mar 2018 12:53:35 +0000
Subject: Re: [bitcoin-dev] version.relay behavior change
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Mar 2018 09:17:26 -0000
--Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thanks for the reply Andrew. I=E2=80=99ve reviewed the relevant Core sources=
and I do not see any problem. We have also synced against a Core node local=
ly and not seen the problem.
The reason I suspected it was Core is that it is very common and all of the U=
ser Agents are consistent (with an occasional exception for forked nodes). S=
o there=E2=80=99s no easy way to determine what sort of nodes we are seeing.=
=20
We tend to cycle through many more connections during sync than a Core node,=
so may just be seeing it more frequently, but I assume Core would log this b=
ehavior as well. Even so, seeing that wouldn=E2=80=99t help much. I=E2=80=99=
m as certain as I can be at this point that we are setting the flag and vers=
ion correctly (and that we do not set bip37 filters).
This behavior started infrequently with 0.14.0 peers and has become more com=
mon over time. Just wondering at this point what fork would report as Core a=
nd be that common? We used to drop peers that did this (for protocol noncomp=
liance), and I=E2=80=99m considering reinstating that behavior.
e
> On Mar 9, 2018, at 16:33, Andrew Chow via bitcoin-dev <bitcoin-dev@lists.l=
inuxfoundation.org> wrote:
>=20
> Looking through the code, I don't think that this behavior has changed. Ar=
e you sure that you are actually connected to Satoshi:0.15.0 nodes and not a=
node that has simply set their user-agent to that (i.e. not a real Satoshi:=
0.15.0 node)?
>=20
> If what you are seeing is true, it is likely a bug and not an intentional c=
hange. In that case, can you provide specific details on how to reproduce?
>=20
> Andrew
>=20
>> On 03/09/2018 02:50 AM, Eric Voskuil via bitcoin-dev wrote:
>> /Satoshi:0.15.0/ and later nodes appear to be no longer honoring the
>> version.relay=3Dfalse flag (BIP37). Could someone familiar with the chang=
e
>> please explain the rational?
>>=20
>> Thanks,
>>=20
>> e
>>=20
>>=20
>>=20
>> _______________________________________________
>> bitcoin-dev mailing list
>> bitcoin-dev@lists.linuxfoundation.org
>> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>=20
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
--Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div></div><div>Thanks for the reply Andrew=
. I=E2=80=99ve reviewed the relevant Core sources and I do not see any probl=
em. We have also synced against a Core node locally and not seen the problem=
.</div><div><br></div><div>The reason I suspected it was Core is that it is v=
ery common and all of the User Agents are consistent (with an occasional exc=
eption for forked nodes). So there=E2=80=99s no easy way to determine what s=
ort of nodes we are seeing. </div><div><br></div><div>We tend to cycle t=
hrough many more connections during sync than a Core node, so may just be se=
eing it more frequently, but I assume Core would log this behavior as well. E=
ven so, seeing that wouldn=E2=80=99t help much. I=E2=80=99m as certain as I c=
an be at this point that we are setting the flag and version correctly (and t=
hat we do not set bip37 filters).</div><div><br></div><div>This behavior sta=
rted infrequently with 0.14.0 peers and has become more common over time. Ju=
st wondering at this point what fork would report as Core and be that common=
? We used to drop peers that did this (for protocol noncompliance), and I=E2=
=80=99m considering reinstating that behavior.</div><div><br></div><div>e</d=
iv><div><br>On Mar 9, 2018, at 16:33, Andrew Chow via bitcoin-dev <<a hre=
f=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@lists.linuxfo=
undation.org</a>> wrote:<br><br></div><blockquote type=3D"cite"><div>
=20
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf-8"=
>
=20
=20
<p>Looking through the code, I don't think that this behavior has
changed. Are you sure that you are actually connected to
Satoshi:0.15.0 nodes and not a node that has simply set their
user-agent to that (i.e. not a real Satoshi:0.15.0 node)?</p>
<p>If what you are seeing is true, it is likely a bug and not an
intentional change. In that case, can you provide specific details
on how to reproduce?</p>
<p>Andrew<br>
</p>
<br>
<div class=3D"moz-cite-prefix">On 03/09/2018 02:50 AM, Eric Voskuil
via bitcoin-dev wrote:<br>
</div>
<blockquote type=3D"cite" cite=3D"mid:e2fd3226-91ff-d0ca-67c7-2c4a98c662=
8f@voskuil.org">
<pre wrap=3D"">/Satoshi:0.15.0/ and later nodes appear to be no longer=
honoring the
version.relay=3Dfalse flag (BIP37). Could someone familiar with the change
please explain the rational?
Thanks,
e
</pre>
<br>
<fieldset class=3D"mimeAttachmentHeader"></fieldset>
<br>
<pre wrap=3D"">_______________________________________________
bitcoin-dev mailing list
<a class=3D"moz-txt-link-abbreviated" href=3D"mailto:bitcoin-dev@lists.linux=
foundation.org">bitcoin-dev@lists.linuxfoundation.org</a>
<a class=3D"moz-txt-link-freetext" href=3D"https://lists.linuxfoundation.org=
/mailman/listinfo/bitcoin-dev">https://lists.linuxfoundation.org/mailman/lis=
tinfo/bitcoin-dev</a>
</pre>
</blockquote>
<br>
=20
</div></blockquote><blockquote type=3D"cite"><div><span>____________________=
___________________________</span><br><span>bitcoin-dev mailing list</span><=
br><span><a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-de=
v@lists.linuxfoundation.org</a></span><br><span><a href=3D"https://lists.lin=
uxfoundation.org/mailman/listinfo/bitcoin-dev">https://lists.linuxfoundation=
.org/mailman/listinfo/bitcoin-dev</a></span><br></div></blockquote></body></=
html>=
--Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D--
|
