1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <mh.in.england@gmail.com>) id 1VS4H6-0007BO-DG
for bitcoin-development@lists.sourceforge.net;
Fri, 04 Oct 2013 12:14:28 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.214.41 as permitted sender)
client-ip=209.85.214.41; envelope-from=mh.in.england@gmail.com;
helo=mail-bk0-f41.google.com;
Received: from mail-bk0-f41.google.com ([209.85.214.41])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1VS4H3-0001hL-RK
for bitcoin-development@lists.sourceforge.net;
Fri, 04 Oct 2013 12:14:28 +0000
Received: by mail-bk0-f41.google.com with SMTP id na10so1549282bkb.28
for <bitcoin-development@lists.sourceforge.net>;
Fri, 04 Oct 2013 05:14:19 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.205.14.69 with SMTP id pp5mr12751114bkb.14.1380888859293;
Fri, 04 Oct 2013 05:14:19 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.204.237.74 with HTTP; Fri, 4 Oct 2013 05:14:19 -0700 (PDT)
In-Reply-To: <20131004115300.GA22215@savin>
References: <CANEZrP1Sd8cK2YUr4OSvnOxEJrbWpmfdpor-qbap1f98tGqPwg@mail.gmail.com>
<20131004115300.GA22215@savin>
Date: Fri, 4 Oct 2013 14:14:19 +0200
X-Google-Sender-Auth: 6PZi2aTMHwI35YK3bjASfjzWgX4
Message-ID: <CANEZrP3e4G_XJy4wDc6VeeBfPG3p4dJ4tpcB8PTwMCNn4+=9Yg@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Peter Todd <pete@petertodd.org>
Content-Type: multipart/alternative; boundary=20cf30223a83ef00a904e7e93d54
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(mh.in.england[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information. [URIs: petertodd.org]
1.0 HTML_MESSAGE BODY: HTML included in message
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1VS4H3-0001hL-RK
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Code review
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2013 12:14:28 -0000
--20cf30223a83ef00a904e7e93d54
Content-Type: text/plain; charset=UTF-8
On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd <pete@petertodd.org> wrote:
> When I'm reviewing multiple commit pull-requests and want to see every
> change made, I always either click on the "Files Changed" tab on github,
> which collapses every commit into a single diff, or do the equivalent
> with git log.
>
> Why doesn't that work for you?
>
The files changed tab definitely works better for reading. In the past
comments I put there have disappeared, but I think that can also be true of
comments put on the individual commit reviews (which is another issue with
github, but it's unrelated to how the commits are presented). So I have
lost trust in doing reviews that way. It does make things easier to read
though.
One advantage of using github is that they're an independent third
> party; we should think carefully about the risks of furthering the
> impression that Bitcoin development is a closed process by moving the
> code review it to a server that we control with explicit review groups.
>
I guess anyone would be able to sign up and comment.
--20cf30223a83ef00a904e7e93d54
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd <span dir=3D"lt=
r"><<a href=3D"mailto:pete@petertodd.org" target=3D"_blank">pete@peterto=
dd.org</a>></span> wrote:<br><div class=3D"gmail_extra"><div class=3D"gm=
ail_quote">
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"im"><span style=3D"color:rgb(3=
4,34,34)">When I'm reviewing multiple commit pull-requests and want to =
see every</span><br>
</div>
change made, I always either click on the "Files Changed" tab on =
github,<br>
which collapses every commit into a single diff, or do the equivalent<br>
with git log.<br>
<br>
Why doesn't that work for you?<br></blockquote><div><br></div><div>The =
files changed tab definitely works better for reading. In the past comments=
I put there have disappeared, but I think that can also be true of comment=
s put on the individual commit reviews (which is another issue with github,=
but it's unrelated to how the commits are presented). So I have lost t=
rust in doing reviews that way. It does make things easier to read though.<=
/div>
<div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">
<div class=3D"im"><span style=3D"color:rgb(34,34,34)">One advantage of usin=
g github is that they're an independent third</span><br></div>
party; we should think carefully about the risks of furthering the<br>
impression that Bitcoin development is a closed process by moving the<br>
code review it to a server that we control with explicit review groups.<br>=
</blockquote><div><br></div><div>I guess anyone would be able to sign up an=
d comment.</div><div><br></div></div></div></div>
--20cf30223a83ef00a904e7e93d54--
|
