1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <jgarzik@bitpay.com>) id 1VQojz-0003ul-Q9
for bitcoin-development@lists.sourceforge.net;
Tue, 01 Oct 2013 01:27:07 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of bitpay.com
designates 209.85.212.169 as permitted sender)
client-ip=209.85.212.169; envelope-from=jgarzik@bitpay.com;
helo=mail-wi0-f169.google.com;
Received: from mail-wi0-f169.google.com ([209.85.212.169])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1VQojy-0005DB-0l
for bitcoin-development@lists.sourceforge.net;
Tue, 01 Oct 2013 01:27:07 +0000
Received: by mail-wi0-f169.google.com with SMTP id hj3so4590092wib.2
for <bitcoin-development@lists.sourceforge.net>;
Mon, 30 Sep 2013 18:26:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:date
:message-id:subject:from:to:cc:content-type;
bh=wCHRD1g/oRv4OdwWQHk7ipRxeJdzm2/feNvJVb/R5ig=;
b=JRz3G4i7WQPZy7Qek490ntYb6XmkxdxoLoe8M+OIsrX2sdRQxKuCIlO0mV2V2l3VbC
BkxdoEjjLystBnidJsXst9HVx+P4EMDk2Ayx7+IpLUVy2UMkom6iAZYAp0XmDeHRg7x/
eQ5Bft4T4THjoQhKmWyU8T1S85kIXrqjtQTZeVPQQilr9x5i9O2peir+yj7WR8Z9i+jI
OaG75LeQR/HpsXkHX/0SYiMJmbvURGjvadsV285XWmVQwVh0X4z4sn23XR/Xy4AiIrYi
GWrCMyd4WtlPGdZUm2dT6Cmv+2V32Sj8zJKDMesaoqZfCO4L7GuX4yoviet2PXvOYr6M
OJRQ==
X-Gm-Message-State: ALoCoQn3A5+hwquyrUIXFL/sdilesuXmYzo8d1w/jkwMzvH8xMrc7TlX0Hc4uHqiJm+b3m1BXsX0
MIME-Version: 1.0
X-Received: by 10.194.201.202 with SMTP id kc10mr20189423wjc.1.1380590819815;
Mon, 30 Sep 2013 18:26:59 -0700 (PDT)
Received: by 10.194.236.69 with HTTP; Mon, 30 Sep 2013 18:26:59 -0700 (PDT)
In-Reply-To: <CAEz79PrGKH27GkDkM2whAdOYYj6-hc954Z=9v1GanBRQA3chvA@mail.gmail.com>
References: <CAJna-Hi+eyRnZUtHpfvod_uRCmjPOL5HS3ZZpr54yzbKRRT9-w@mail.gmail.com>
<CAEz79PrGKH27GkDkM2whAdOYYj6-hc954Z=9v1GanBRQA3chvA@mail.gmail.com>
Date: Tue, 1 Oct 2013 03:26:59 +0200
Message-ID: <CAJHLa0NX-hfRu1YOK1tqb5j_Y8QxC6YZPjj7rc+3NjqNxrH4qg@mail.gmail.com>
From: Jeff Garzik <jgarzik@bitpay.com>
To: "Warren Togami Jr." <wtogami@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: -1.6 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information. [URIs: bitpay.com]
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1VQojy-0005DB-0l
Cc: "bitcoin-development@lists.sourceforge.net"
<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] bitcoind stops responding
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 01 Oct 2013 01:27:07 -0000
On Mon, Sep 30, 2013 at 11:01 PM, Warren Togami Jr. <wtogami@gmail.com> wrote:
> 0.8.2 apparently was the first Bitcoin version to support RPC keepalive.
No, this is not correct at all. RPC keepalive was present in 0.7.0,
possibly earlier.
Come on, it took a 30 second 'git checkout' session to verify this.
> With the 4 RPC thread limit, four keepalive connections will exhaust all four and prevent further connections.
I was about to flame you with a "WTF is this fiction?" but it seems
true: 21eb5ada introduces this.
Unfortunately, it does so erroneously, introducing clearly buggy
behavior that did not exist with the thread-per-connection code that
provided keep-alive before commit 21eb5ada.
In my opinion, 21eb5ada half-changed the RPC code from
thread-per-connection to a worker-group model, without considering all
the consequences.
--
Jeff Garzik
Senior Software Engineer and open source evangelist
BitPay, Inc. https://bitpay.com/
|
