Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1RHumk-000544-AH for bitcoin-development@lists.sourceforge.net; Sun, 23 Oct 2011 09:56:06 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.213.47 as permitted sender) client-ip=209.85.213.47; envelope-from=witchspace81@gmail.com; helo=mail-yw0-f47.google.com; Received: from mail-yw0-f47.google.com ([209.85.213.47]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1RHumj-0005R6-Ku for bitcoin-development@lists.sourceforge.net; Sun, 23 Oct 2011 09:56:06 +0000 Received: by ywf9 with SMTP id 9so3165187ywf.34 for ; Sun, 23 Oct 2011 02:56:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.50.8 with SMTP id y8mr1844147obn.79.1319363760161; Sun, 23 Oct 2011 02:56:00 -0700 (PDT) Received: by 10.182.34.226 with HTTP; Sun, 23 Oct 2011 02:56:00 -0700 (PDT) In-Reply-To: References: Date: Sun, 23 Oct 2011 11:56:00 +0200 Message-ID: From: John Smith To: Bitcoin Dev Content-Type: multipart/alternative; boundary=f46d0444741d41044e04aff45066 X-Spam-Score: -0.5 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (witchspace81[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.1 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (witchspace81[at]gmail.com) 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1RHumj-0005R6-Ku Subject: [Bitcoin-development] Fwd: bitcoin scope issue in main.cpp X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Oct 2011 09:56:06 -0000 --f46d0444741d41044e04aff45066 Content-Type: text/plain; charset=ISO-8859-1 FYI It's in a disabled feature (replacement), so I'm not sure how important this is, but it doesn't look good. ---------- Forwarded message ---------- From: Dean Gores Date: Sun, Oct 23, 2011 at 11:15 AM Subject: bitcoin scope issue in main.cpp To: laanwj@gmail.com You have "i" and "output" declared in the same scope in "main.cpp", AcceptToMemoryPool. Below is the offending code. for (int i = 0; i < vin.size(); i++) { COutPoint outpoint = vin[i].prevout; if (!mapNextTx.count(outpoint) || mapNextTx[outpoint].ptx != ptxOld) return false; } Cheers, Dean Gores --f46d0444741d41044e04aff45066 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable FYI
It's in a disabled feature (replacement), so I'm not sure ho= w important this is, but it doesn't look good.

---------- Forwarded message ---------= -
From: Dean Gores <dmgores@gmail.com&= gt;
Date: Sun, Oct 23, 2011 at 11:15 AM
Subject: bitcoin scope issue in main.cpp
To: laanwj@gmail.com


You have "i= " and "output" declared in the same scope in "main.cpp&= quot;,
AcceptToMemoryPool. =A0Below is the offending code.

=A0 =A0 =A0 =A0 =A0 =A0for (int i =3D 0; i < vin.size(); i++)
=A0 =A0 =A0 =A0 =A0 =A0{
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0COutPoint outpoint =3D vin[i].prevout;
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (!mapNextTx.count(outpoint) ||
mapNextTx[outpoint].ptx !=3D ptxOld)
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return false;
=A0 =A0 =A0 =A0 =A0 =A0}


Cheers,
Dean Gores


--f46d0444741d41044e04aff45066--