Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1R4B0U-0001U8-KC for bitcoin-development@lists.sourceforge.net; Thu, 15 Sep 2011 12:25:30 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.161.47 as permitted sender) client-ip=209.85.161.47; envelope-from=gavinandresen@gmail.com; helo=mail-fx0-f47.google.com; Received: from mail-fx0-f47.google.com ([209.85.161.47]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1R4B0T-0004c6-Se for bitcoin-development@lists.sourceforge.net; Thu, 15 Sep 2011 12:25:30 +0000 Received: by fxi1 with SMTP id 1so785678fxi.34 for ; Thu, 15 Sep 2011 05:25:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.63.8 with SMTP id z8mr799193fah.84.1316089523356; Thu, 15 Sep 2011 05:25:23 -0700 (PDT) Received: by 10.152.25.105 with HTTP; Thu, 15 Sep 2011 05:25:23 -0700 (PDT) In-Reply-To: References: Date: Thu, 15 Sep 2011 08:25:23 -0400 Message-ID: From: Gavin Andresen To: Mike Hearn Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gavinandresen[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1R4B0T-0004c6-Se Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] Request review: drop misbehaving peers X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2011 12:25:30 -0000 Thanks Mike, that's exactly the kind of detailed review I was looking for. I think you're right an all points. I'll simplify: I'll add a -banscore option (default 100), and if a node accumulates more than -banscore misbehavior points it'll get dropped and banned for -bantime (default 60*60*24) seconds. I'll make bad signatures a banning offense, and I'll remove the number-of-sigops and non-standard-transaction penalties. I used a mutable field with const setter to avoid modifying a bunch of methods to take non-const blocks/transactions instead of const; I think it is appropriate because a block/transaction's DoS score is really meta-data and not part of it's state. I'll make GetTime() unit-test friendly as you suggest. -- -- Gavin Andresen