Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UpErd-0005Rz-82 for bitcoin-development@lists.sourceforge.net; Wed, 19 Jun 2013 09:39:41 +0000 Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.219.48 as permitted sender) client-ip=209.85.219.48; envelope-from=mh.in.england@gmail.com; helo=mail-oa0-f48.google.com; Received: from mail-oa0-f48.google.com ([209.85.219.48]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1UpErc-0002Qq-4G for bitcoin-development@lists.sourceforge.net; Wed, 19 Jun 2013 09:39:41 +0000 Received: by mail-oa0-f48.google.com with SMTP id f4so6284515oah.35 for ; Wed, 19 Jun 2013 02:39:34 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.33.234 with SMTP id u10mr1466282oei.29.1371634774741; Wed, 19 Jun 2013 02:39:34 -0700 (PDT) Sender: mh.in.england@gmail.com Received: by 10.76.23.36 with HTTP; Wed, 19 Jun 2013 02:39:34 -0700 (PDT) In-Reply-To: <1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com> References: <1371577555.61696.YahooMailNeo@web162703.mail.bf1.yahoo.com> <1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com> Date: Wed, 19 Jun 2013 11:39:34 +0200 X-Google-Sender-Auth: RTpEM_RZXwfYxc5CeJz6bepKa4c Message-ID: From: Mike Hearn To: Turkey Breast Content-Type: multipart/alternative; boundary=089e013c7042829e4504df7e9b9e X-Spam-Score: -0.5 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mh.in.england[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1UpErc-0002Qq-4G Cc: "bitcoin-development@lists.sourceforge.net" Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 09:39:41 -0000 --089e013c7042829e4504df7e9b9e Content-Type: text/plain; charset=UTF-8 It has to be optional because old clients don't send it, obviously. Why is this even an issue? There's no problem with variable length messages in any codebase that I'm aware of. Is this solving some actual problem? On Wed, Jun 19, 2013 at 12:30 AM, Turkey Breast wrote: > That's me. I never said to make all messages fixed length. I said to make > a fixed number of fields per protocol. So given a protocol version number, > you know the number of fields in a message. This is not only easier for > parsing messages, but just good practice. I don't see why a 1 byte flag > needs to be optional anyway. > > ------------------------------ > *From:* Mike Hearn > *To:* Turkey Breast > *Cc:* Bitcoin Dev > *Sent:* Tuesday, June 18, 2013 9:48 PM > *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message > > It's not a bug (although there was recently a change to make bitcoind/qt > always send this field anyway). > > I don't know where Amir is going with BIP 60. Version messages have always > been variable length. There's nothing inherent in the Bitcoin protocol that > says all messages are fixed length, indeed, tx messages are allowed to have > arbitrary data appended after them that gets relayed. > > > On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast wrote: > > See this BIP. I'm not sure if this is a bug or what, but it would be good > if messages always had a fixed number of fields per protocol version. > > https://en.bitcoin.it/wiki/BIP_0060#Code_Updates > > This BIP details everything that needs to be done and proposes a protocol > upgrade. > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development > > > > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development > > --089e013c7042829e4504df7e9b9e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
It has to be optional because old clients don't send i= t, obviously.

Why is this even an issue? There'= ;s no problem with variable length messages in any codebase that I'm aw= are of. Is this solving some actual problem?


On Wed,= Jun 19, 2013 at 12:30 AM, Turkey Breast <turkeybreast@yahoo.com&= gt; wrote:
That's me. I never s= aid to make all messages fixed length. I said to make a fixed number of fie= lds per protocol. So given a protocol version number, you know the number o= f fields in a message. This is not only easier for parsing messages, but ju= st good practice. I don't see why a 1 byte flag needs to be optional an= yway.

From: Mike Hearn <= ;mike@plan99.net&g= t;
To: Turkey Breast <= ;turkeybreast@y= ahoo.com>
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
= Sent: Tuesday, June 18, 201= 3 9:48 PM
Subject: Re: [Bitcoin-devel= opment] Missing fRelayTxes in version message
=

It's not a bug (although there was recently a cha= nge to make bitcoind/qt always send this field anyway).=C2=A0

I don't know where Amir is going with BIP 60. Version messages ha= ve always been variable length. There's nothing inherent in the Bitcoin= protocol that says all messages are fixed length, indeed, tx messages are = allowed to have arbitrary data appended after them that gets relayed.


On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast <turkeybreast@yahoo.com> wrote:
See this BIP. I'm not sure if this is a bug or w= hat, but it would be good if messages always had a fixed number of fields p= er protocol version.


This BIP details everything that needs to be done and proposes a protocol u= pgrade.

------------------------------------------= ------------------------------------
This SF.net email is spons= ored by Windows:

Build for Windows Store.

http://p.= sf.net/sfu/windows-dev2dev
_________________________________________= ______
Bitcoin-development mailing list
Bitcoin-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/li= stinfo/bitcoin-development





-----------= -------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.= sf.net/sfu/windows-dev2dev
_________________________________________= ______
Bitcoin-development mailing list
Bitcoin-develo= pment@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-de= velopment


--089e013c7042829e4504df7e9b9e--