MIME-Version: 1.0
References: <CAPg+sBhuPG-2GXc+Bp0yv5ywry2fk56LPLT4AY0Kcs+YEoz4FA@mail.gmail.com>
	<CAMZUoK==Bdn73Lc=swgf2F5_mqE84TR1GRBFhrFkn7kab4jBaw@mail.gmail.com>
	<20181123050330.x4xrgouit7apwk45@erisian.com.au>
In-Reply-To: <20181123050330.x4xrgouit7apwk45@erisian.com.au>
From: "Russell O'Connor" <roconnor@blockstream.io>
Date: Fri, 23 Nov 2018 15:18:13 -0500
Message-ID: <CAMZUoK=SC3+d73SNfu7rAdwE4tcJK6jmg9-UHDJVN53ZU_HqMw@mail.gmail.com>
To: Anthony Towns <aj@erisian.com.au>
Content-Type: multipart/alternative; boundary="00000000000082ffc5057b5aafe0"
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Safer sighashes and more granular SIGHASH_NOINPUT
Precedence: list

--00000000000082ffc5057b5aafe0
Content-Type: text/plain; charset="UTF-8"

On Fri, Nov 23, 2018 at 12:03 AM Anthony Towns <aj@erisian.com.au> wrote:

> On Wed, Nov 21, 2018 at 12:07:30PM -0500, Russell O'Connor via bitcoin-dev
> wrote:
> > Given that we want to move away from OP_CODESEPARATOR, because each call
> to
> > this operation effectively takes O(script-size) time, we need a
> replacement for
> > the functionality it currently provides.  While perhaps the original
> motivation
> > for OP_CODESEPARTOR is surrounded in mystery, it currently can be used
> (or
> > perhaps abused) for the task of creating signature that covers, not only
> which
> > input is being signed, but which specific branch within that input
> Script code
> > is being signed for.
>
> Would it be sufficient to sign the position within the script of the
> last OP_CODESEPARATOR? That is, if your script is:
>
> I think that covers all the behaviour you can currently achieve with
> CODESEP (which is pretty limited since every sig effectively commits
> to the full redeem script, and you can't commit to subsets of the
> signature/witness), and it keeps the things you can do with the various
> features a bit orthogonal:
>

Thanks for bringing this up.  I was thinking the same thing as well, that
yes that should be sufficient to cover the semantics of OP_CODESEPARATOR.
Though to be more precise you would sign the position of the last
_executed_ OP_CODESEPARATOR.

That said, while I agree the above is a superior realization of the
OP_CODESEPARATOR, given that we are probably going to support
OP_CODESEPARATOR inside legacy P2SH scripts indefinitely, it is probably
better to keep the existing akward implementation of OP_CODESEPARATOR in
future versions of Script.  (At least until we decide to stop mangling the
Script consensus code with more and more flag combinations and decide it is
better to cut and paste code for new versions of Script to help ensure we
don't make consensus changes to legacy behaviour).


> [0] (I think I'm going to claim "MAST" stands for "merkelized alternative
>      script tree" these days, since they're not "abstract syntax trees")
>

:thumbs-up:

Sorry for hijacking the thread about OP_MASK and friends.

--00000000000082ffc5057b5aafe0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div class=3D"gmail_quote"><div dir=3D"ltr">On Fri, N=
ov 23, 2018 at 12:03 AM Anthony Towns &lt;<a href=3D"mailto:aj@erisian.com.=
au">aj@erisian.com.au</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex=
">On Wed, Nov 21, 2018 at 12:07:30PM -0500, Russell O&#39;Connor via bitcoi=
n-dev wrote:<br>
&gt; Given that we want to move away from OP_CODESEPARATOR, because each ca=
ll to<br>
&gt; this operation effectively takes O(script-size) time, we need a replac=
ement for<br>
&gt; the functionality it currently provides.=C2=A0 While perhaps the origi=
nal motivation<br>
&gt; for OP_CODESEPARTOR is surrounded in mystery, it currently can be used=
 (or<br>
&gt; perhaps abused) for the task of creating signature that covers, not on=
ly which<br>
&gt; input is being signed, but which specific branch within that input Scr=
ipt code<br>
&gt; is being signed for.<br>
<br>
Would it be sufficient to sign the position within the script of the<br>
last OP_CODESEPARATOR? That is, if your script is:<br>
<br>
I think that covers all the behaviour you can currently achieve with<br>
CODESEP (which is pretty limited since every sig effectively commits<br>
to the full redeem script, and you can&#39;t commit to subsets of the<br>
signature/witness), and it keeps the things you can do with the various<br>
features a bit orthogonal:<br></blockquote><div><br></div><div>Thanks for b=
ringing this up.=C2=A0 I was thinking the same thing as well, that yes that=
 should be sufficient to cover the semantics of OP_CODESEPARATOR.=C2=A0 Tho=
ugh to be more precise you would sign the position of the last _executed_ O=
P_CODESEPARATOR.</div><div><br></div><div>That said, while I agree the abov=
e is a superior realization of the OP_CODESEPARATOR, given that we are prob=
ably going to support OP_CODESEPARATOR inside legacy P2SH scripts indefinit=
ely, it is probably better to keep the existing akward implementation of OP=
_CODESEPARATOR in future versions of Script.=C2=A0 (At least until we decid=
e to stop mangling the Script consensus code with more and more flag combin=
ations and decide it is better to cut and paste code for new versions of Sc=
ript to help ensure we don&#39;t make consensus changes to legacy behaviour=
).<br></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">[0] (I think I&=
#39;m going to claim &quot;MAST&quot; stands for &quot;merkelized alternati=
ve<br>
=C2=A0 =C2=A0 =C2=A0script tree&quot; these days, since they&#39;re not &qu=
ot;abstract syntax trees&quot;)<br></blockquote><div><br></div><div>:thumbs=
-up: <br></div><div><br></div><div>Sorry for hijacking the thread about OP_=
MASK and friends.<br></div></div></div></div>

--00000000000082ffc5057b5aafe0--