Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.214.54 as permitted sender)
	client-ip=209.85.214.54; envelope-from=mh.in.england@gmail.com;
	helo=mail-bk0-f54.google.com; 
MIME-Version: 1.0
Sender: mh.in.england@gmail.com
In-Reply-To: <CABsx9T1Q85usG4mhgLJTnK5pMUDwd1Ek3FmG0Z+-3vxg80xX0Q@mail.gmail.com>
References: <CANEZrP1Sd8cK2YUr4OSvnOxEJrbWpmfdpor-qbap1f98tGqPwg@mail.gmail.com>
	<CABsx9T1Q85usG4mhgLJTnK5pMUDwd1Ek3FmG0Z+-3vxg80xX0Q@mail.gmail.com>
Date: Sat, 5 Oct 2013 13:36:26 +0200
Message-ID: <CANEZrP3WLw4OgbUqT6ejD8WpuaeG15yc2m5Y+Hz3RJT4JZwkkw@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Gavin Andresen <gavinandresen@gmail.com>
Content-Type: multipart/alternative; boundary=001a1132ec9057280b04e7fcd449
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Code review
Precedence: list

--001a1132ec9057280b04e7fcd449
Content-Type: text/plain; charset=UTF-8

On Sat, Oct 5, 2013 at 4:31 AM, Gavin Andresen <gavinandresen@gmail.com>wrote:

> I'll try harder to be a fascist (it doesn't come naturally to me). HUGE
> thanks for taking the time to review the fee changes in detail.
>

Thanks, although I wasn't thinking specifically of you. The fee pull is
pretty well laid out. It just reminded me that it seems to be a common
issue I've had over the past year or so, across projects and people.


> I'm all for using better tools, if they will actually get used. If a
> potential reviewer has to sign up to create a Review Board account or learn
> Yet Another Tool, then I think it would be counter-productive:  we'd just
> make the pool of reviewers even smaller than it already is.
>

Yes, I don't know if github supports any kind of SSO. I will investigate.
As for learning another tool, well, when the current tool kind of sucks I
don't see any way around that one :)


> Are there good examples of other open source software projects
> successfully incentivizing review that we can copy?
>
> For example, I'm wondering if maybe for the 0.9 release and onwards the
> "Thank you" section should thank only people who have significantly helped
> test or review other people's code.
>

Perhaps just have a separate section for people who helped review above the
current section? It seems a bit mean not to credit occasional contributors
who fixed bugs or maintained something important but didn't review
complicated changes to the core.

--001a1132ec9057280b04e7fcd449
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Sat, Oct 5, 2013 at 4:31 AM, Gavin Andresen <span dir=
=3D"ltr">&lt;<a href=3D"mailto:gavinandresen@gmail.com" target=3D"_blank">g=
avinandresen@gmail.com</a>&gt;</span> wrote:<br><div class=3D"gmail_extra">=
<div class=3D"gmail_quote">
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div class=3D"im"><span sty=
le=3D"color:rgb(34,34,34)">I&#39;ll try harder to be a fascist (it doesn=
9;t come naturally to me). HUGE thanks for taking the time to review the fe=
e changes in detail.</span></div>
</div></blockquote><div><br></div><div>Thanks, although I wasn&#39;t thinki=
ng specifically of you. The fee pull is pretty well laid out. It just remin=
ded me that it seems to be a common issue I&#39;ve had over the past year o=
r so, across projects and people.</div>
<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div class=
=3D"im"><span style=3D"color:rgb(34,34,34)">I&#39;m all for using better to=
ols, if they will actually get used. If a potential reviewer has to sign up=
 to create a Review Board account or learn Yet Another Tool, then I think i=
t would be counter-productive: =C2=A0we&#39;d just make the pool of reviewe=
rs even smaller than it already is.</span></div>
</div></blockquote><div><br></div><div>Yes, I don&#39;t know if github supp=
orts any kind of SSO. I will investigate. As for learning another tool, wel=
l, when the current tool kind of sucks I don&#39;t see any way around that =
one :)</div>
<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div class=
=3D"im"><span style=3D"color:rgb(34,34,34)">Are there good examples of othe=
r open source software projects successfully incentivizing review that we c=
an copy?</span><br>
</div><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div><br></div>=
<div>For example, I&#39;m wondering if maybe for the 0.9 release and onward=
s the &quot;Thank you&quot; section should thank only people who have signi=
ficantly helped test or review other people&#39;s code.</div>
</div></div></div></blockquote><div><br></div><div>Perhaps just have a sepa=
rate section for people who helped review above the current section? It see=
ms a bit mean not to credit occasional contributors who fixed bugs or maint=
ained something important but didn&#39;t review complicated changes to the =
core.=C2=A0</div>
</div></div></div>

--001a1132ec9057280b04e7fcd449--