MIME-Version: 1.0
In-Reply-To: <10E4880B-1B3F-40AF-88DD-65D152533DFC@petertodd.org>
References: <CAFp6fsHBbyVo21DnQKGBVJ7P=8NqOGJ-jv0-MH9WaBD6vauudA@mail.gmail.com>
	<CAE-z3OUKTKh5-SHkiawr4R58Fdg9N6_1PLjW19YsF-K9OOjQow@mail.gmail.com>
	<CAFp6fsEq0So3nUtRrn1G3Q-sEFUpK7myxfvT9-p9LNkxPGYoTw@mail.gmail.com>
	<10E4880B-1B3F-40AF-88DD-65D152533DFC@petertodd.org>
Date: Thu, 24 Sep 2015 14:56:23 -0400
Message-ID: <CAFp6fsFgkGV93PrdJPXnS880weNX=bXd17H1u5V7VBucTtW=7A@mail.gmail.com>
From: Suhas Daftuar <sdaftuar@gmail.com>
To: Peter Todd <pete@petertodd.org>
Content-Type: multipart/alternative; boundary=001a11c2f316987324052082c960
Cc: Suhas Daftuar via bitcoin-dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] [BIP Proposal] New "sendheaders" p2p message
Precedence: list

--001a11c2f316987324052082c960
Content-Type: text/plain; charset=UTF-8

I considered that as well, but it seemed to me that other software on the
network (say, different wallet implementations) might prefer the option of
being able to bump up their protocol version in the future to pick up some
other change, without having to also opt-in to receiving
headers-announcements for blocks.

In particular, inv-based block announcements aren't going away (even in my
implementation of headers announcements, there are some edge cases where
the code would need to fall back to an inv announcement), so forcing all
software on the network to upgrade to supporting headers announcements,
whether now or in the future, seems too drastic -- I could imagine some
software not being very concerned about optimizing block relay in this
particular way.

On Thu, Sep 24, 2015 at 2:41 PM, Peter Todd <pete@petertodd.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> On 24 September 2015 14:37:40 GMT-04:00, Suhas Daftuar via bitcoin-dev <
> bitcoin-dev@lists.linuxfoundation.org> wrote:
> >On Thu, Sep 24, 2015 at 2:17 PM, Tier Nolan via bitcoin-dev <
> >bitcoin-dev@lists.linuxfoundation.org> wrote:
> >
> >>
> >> Is there actually a requirement for the new message?  New nodes could
> >just
> >> unilaterally switch to sending headers and current nodes would be
> >> compatible.
> >>
> >
> >I don't believe that unilaterally switching to headers announcements
> >would
> >work for all network participants -- both for users running older
> >Bitcoin
> >Core versions (anything before 0.10, which I believe all ignore headers
> >messages) and for non-Bitcoin Core software that participates on the
> >network (which may ignore headers messages too, I'm not sure what all
> >is
> >out there).
>
> You can enable the behaviour based on advertised p2p network version.
> -----BEGIN PGP SIGNATURE-----
>
> iQE9BAEBCgAnIBxQZXRlciBUb2RkIDxwZXRlQHBldGVydG9kZC5vcmc+BQJWBEO5
> AAoJEMCF8hzn9Lncz4MH/3ztGWdFvMWWcwQsjIRH+eP6PH57WaEru1smmFYOmKrj
> djdiRVdxfChxRqP3adO21RUKKchjl8DNjrFJHPFz75FSM0cDcD0QAGAHilVdnICE
> LEIlTEoiIc0f1z9f/EJHSHPhiUXMnjpl/l7PYJFZV3Lt2Bl30yLsNnrp9qxjR30n
> 3nykZjyRad4JSavdTP6Evd3qaqwGXNUWsdObXNI+WPKlrw6hczlhFDKQ7RC1FPQU
> Rbgb21pavtqLUTwbBZGUisAAc94e2Gama1p3ioUFklbVtLTdw+FtxPgV/0ZS75OR
> V9pCXIbg9VM6QY4+9gYnP635+qCkqAJ4tBsYGmsT8yA=
> =cF4B
> -----END PGP SIGNATURE-----
>
>

--001a11c2f316987324052082c960
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I considered that as well, but it seemed to me that other =
software on the network (say, different wallet implementations) might prefe=
r the option of being able to bump up their protocol version in the future =
to pick up some other change, without having to also opt-in to receiving he=
aders-announcements for blocks.<div><br></div><div>In particular, inv-based=
 block announcements aren&#39;t going away (even in my implementation of he=
aders announcements, there are some edge cases where the code would need to=
 fall back to an inv announcement), so forcing all software on the network =
to upgrade to supporting headers announcements, whether now or in the futur=
e, seems too drastic -- I could imagine some software not being very concer=
ned about optimizing block relay in this particular way.</div></div><div cl=
ass=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, Sep 24, 2015 at =
2:41 PM, Peter Todd <span dir=3D"ltr">&lt;<a href=3D"mailto:pete@petertodd.=
org" target=3D"_blank">pete@petertodd.org</a>&gt;</span> wrote:<br><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc s=
olid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA512<br>
<span class=3D""><br>
<br>
<br>
On 24 September 2015 14:37:40 GMT-04:00, Suhas Daftuar via bitcoin-dev &lt;=
<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@lists.=
linuxfoundation.org</a>&gt; wrote:<br>
&gt;On Thu, Sep 24, 2015 at 2:17 PM, Tier Nolan via bitcoin-dev &lt;<br>
&gt;<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@li=
sts.linuxfoundation.org</a>&gt; wrote:<br>
&gt;<br>
&gt;&gt;<br>
&gt;&gt; Is there actually a requirement for the new message?=C2=A0 New nod=
es could<br>
&gt;just<br>
&gt;&gt; unilaterally switch to sending headers and current nodes would be<=
br>
&gt;&gt; compatible.<br>
&gt;&gt;<br>
&gt;<br>
&gt;I don&#39;t believe that unilaterally switching to headers announcement=
s<br>
&gt;would<br>
&gt;work for all network participants -- both for users running older<br>
&gt;Bitcoin<br>
&gt;Core versions (anything before 0.10, which I believe all ignore headers=
<br>
&gt;messages) and for non-Bitcoin Core software that participates on the<br=
>
&gt;network (which may ignore headers messages too, I&#39;m not sure what a=
ll<br>
&gt;is<br>
&gt;out there).<br>
<br>
</span>You can enable the behaviour based on advertised p2p network version=
.<br>
-----BEGIN PGP SIGNATURE-----<br>
<br>
iQE9BAEBCgAnIBxQZXRlciBUb2RkIDxwZXRlQHBldGVydG9kZC5vcmc+BQJWBEO5<br>
AAoJEMCF8hzn9Lncz4MH/3ztGWdFvMWWcwQsjIRH+eP6PH57WaEru1smmFYOmKrj<br>
djdiRVdxfChxRqP3adO21RUKKchjl8DNjrFJHPFz75FSM0cDcD0QAGAHilVdnICE<br>
LEIlTEoiIc0f1z9f/EJHSHPhiUXMnjpl/l7PYJFZV3Lt2Bl30yLsNnrp9qxjR30n<br>
3nykZjyRad4JSavdTP6Evd3qaqwGXNUWsdObXNI+WPKlrw6hczlhFDKQ7RC1FPQU<br>
Rbgb21pavtqLUTwbBZGUisAAc94e2Gama1p3ioUFklbVtLTdw+FtxPgV/0ZS75OR<br>
V9pCXIbg9VM6QY4+9gYnP635+qCkqAJ4tBsYGmsT8yA=3D<br>
=3DcF4B<br>
-----END PGP SIGNATURE-----<br>
<br>
</blockquote></div><br></div>

--001a11c2f316987324052082c960--