Date: Thu, 16 Jun 2022 12:47:15 +0000
To: linuxfoundation.cndm1@dralias.com
From: alicexbt <alicexbt@protonmail.com>
Reply-To: alicexbt <alicexbt@protonmail.com>
Message-ID: <PR0Y8mPL6L0jZaTNX8_Qlx9qfRgVD6sYxS6tHNyqOzLPnetSBYkfhR_dmzsGpMCJ8olH5VXXDnMzqkief9ExCoCr41tkXyz36QIrQzACF1M=@protonmail.com>
In-Reply-To: <165535822613.7.2651335771202625212.47284609@dralias.com>
References: <CALZpt+GOh-7weEypT9JrzcwthZJqHOfj7sf9FMuqi5_FZv0g7w@mail.gmail.com>
 <7aP7ve-x6uMLSY2a9ZvpkyEc7uOdWmCGOs-S2ly1klRKzm5kVT4zjC9i0V6k1R0Cr9Xloq6Z4zmZ0LfquOxFtyhrA0RgsfG4qq760T4dfZM=@protonmail.com>
 <CAB3F3DuhMQn_fSiXqqzrUMhDm7D=AiKg4nSO71372WzJFCr9EQ@mail.gmail.com>
 <dYLEcCTOYwMe7umkzbxdFz-sp5ZwqHU6DcpAg8M8p-ANg8QWSafISIzDXhbGiAHlV6eInfar2ll9oWviwox4SZ7QwfgqXkIbgq_fvcaUz0M=@protonmail.com>
 <165535822613.7.2651335771202625212.47284609@dralias.com>
Feedback-ID: 40602938:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Playing with full-rbf peers for fun and L2s
	security
Precedence: list

Hi cndm1,

> If you see a "lack of basic options" and no one has opened a pull request=
 for it, it may be for two reasons.

The basic option to disable all RBF policies in a node's mempool if require=
d was removed in [PR #16171][1]. No one has opened a pull request to revert=
 this because most of the maintainers and a few reviewers agreed with this =
change. It wasn't required, PR had weak rationale, 2 NACKS and was reopened=
 to merge because some reviewers/maintainers believe its a policy that cann=
ot be maintained. One of the reviewers who NACKed it already maintains the =
config option to disable all RBF policies in Bitcoin Knots which is a deriv=
ative of Bitcoin Core.

> However, repeatedly demanding others to do it for you is not helpful in o=
pen source software development.

I am not demanding anyone to add a few lines of code and open a pull reques=
t. I am _reviewing_ a pull request in an open source project and sharing my=
 feedback. Even Antoine and Luke agreed to add it if other reviewers have n=
o issues or I can do it. This option in context with another being added fo=
r a new RBF policy was being discussed in [PR #25353][2] and my earlier ema=
ils in this thread.

Other 'basic options' will be easier to accommodate with `-mempoolreplaceme=
nt` used in [PR #25373] which is unlikely to be merged.

[1]: https://github.com/bitcoin/bitcoin/pull/16171
[2]: https://github.com/bitcoin/bitcoin/pull/25353
[3]: https://github.com/bitcoin/bitcoin/pull/25373


/dev/fd0

Sent with Proton Mail secure email.

------- Original Message -------
On Thursday, June 16th, 2022 at 11:13 AM, linuxfoundation.cndm1--- via bitc=
oin-dev bitcoin-dev@lists.linuxfoundation.org wrote:


> alicexbt wrote:
>
> > I do not have issues with multiple RBF policies being tried out and ful=
l-rbf being one of them. My disagreements are with rationale, lack of basic=
 options in Bitcoin Core to employ/disable different RBF policies and a few=
 arguments made in support for full-rbf. Whether it appears strawman or off=
topic on github, there should be a place to share these disagreements.
>
> Bitcoin Core is open source software, where developers open pull
> requests to try to get them merged after review. If you see a "lack of
> basic options" and no one has opened a pull request for it, it may be
> for two reasons. First, it could be that it just doesn't make sense,
> so no one sees a point in implementing it. Secondly, it may be that it
> isn't on anyone's list of priorities. In the second case, you are
> welcome to share your preference once. Moreover, no one is holding you
> back to implement it yourself and suggest a pull request. However,
> repeatedly demanding others to do it for you is not helpful in open
> source software development.
>
> cndm1
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev