Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.213.47 as permitted sender)
	client-ip=209.85.213.47; envelope-from=laanwj@gmail.com;
	helo=mail-yw0-f47.google.com; 
MIME-Version: 1.0
In-Reply-To: <201203310003.18599.luke@dashjr.org>
References: <201203310003.18599.luke@dashjr.org>
Date: Sat, 31 Mar 2012 09:56:57 +0200
Message-ID: <CA+s+GJCzo6GZDyFh8UEy9BNpO7AAZv4NDcEFDAUz=ZEad2=VMQ@mail.gmail.com>
From: Wladimir <laanwj@gmail.com>
To: Luke-Jr <luke@dashjr.org>
Content-Type: multipart/alternative; boundary=20cf3056397120b66104bc854d73
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] 0.7 merge recommendations/status
Precedence: list

--20cf3056397120b66104bc854d73
Content-Type: text/plain; charset=UTF-8

Thanks for the summary!

On Sat, Mar 31, 2012 at 6:03 AM, Luke-Jr <luke@dashjr.org> wrote:

> It seems to me, there is potentially enough ready to merge into 0.7 to
> start
> the RC process right away if someone wants to... except that the first
> merge
> will probably require rebasing everything else ;)
>

Yes, we have a lot of changes waiting already.


> Next up are some changes already ACK'd for 0.7: Hearn's "pong" message
> (#932)
> and Wladimir's Visual C++ 2010 fixes (#949). getmemorypool BIP
> standardization
> (#936) is also ACK'd, but it might be good to wait until later in the merge
> window considering its low impact and high potential for change as the BIP
> gets closer to Accepted status.
>

Agreed.


>
> any sort of high-volume bitcoind usage (such as solo mining). Some other
> optimizations by Joel such as the optimized ToHex function (#562) and
>

See my comments there; I'm all for optimizing the ToHex function, but I
prefer that he optimizes the current ToHex function not add yet another one
with an incompatible interface.

(we have the same problem with Error/Debug/"Log to console" functions, too
many of them and sometimes it's unclear what the difference is)


> Scott has a pull request for Bitcoin-Qt to behave more like other close-to-
> systray applications by toggling the hide/show action (#855). He's also
> contributed a patch to show miners' immature balances on the overview
> screen
> (#837; it leaves only a blank space for non-miners). Nils, on the other
> hand,
> has been working with a UI designer to totally remodel Bitcoin-Qt.
>

I also have some UI code changes ready, for example one to use notification
from the bitcoin core when the address book/transactions changed, instead
of a timer. Will submit pull requests soon.

Coderrr has rebased his Coin Control features (#415) to the latest version.
> These seem to be popular, so should probably be merged as soon as it's
> had proper review.
>

Agreed. It is very popular and should certainly be merged. And it has seen
quite some testing already. Though this will take some time to review, as
it is quite a large change.


> Finally, I don't know the status of Pieter's IPv6 support, but I hope it
> will
> be ready for 0.7. Right now all I see submitted for this is support for
> multiple local IPs (#829) though.
>
>
IPv6 support would be nice, but I don't think a milestone of 0.7 is
realistic. Such a change to the network code will require extensive
testing. Who has access to IPv6 and can help testing?

Wladimir

--20cf3056397120b66104bc854d73
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks for the summary!<br><br><div class=3D"gmail_quote">On Sat, Mar 31, 2=
012 at 6:03 AM, Luke-Jr <span dir=3D"ltr">&lt;<a href=3D"mailto:luke@dashjr=
.org">luke@dashjr.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_q=
uote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1e=
x">
It seems to me, there is potentially enough ready to merge into 0.7 to star=
t<br>
the RC process right away if someone wants to... except that the first merg=
e<br>
will probably require rebasing everything else ;)<br></blockquote><div><br>=
</div><div>Yes, we have a lot of changes waiting already.</div><div>=C2=A0<=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-le=
ft:1px #ccc solid;padding-left:1ex">
Next up are some changes already ACK&#39;d for 0.7: Hearn&#39;s &quot;pong&=
quot; message (#932)<br>
and Wladimir&#39;s Visual C++ 2010 fixes (#949). getmemorypool BIP standard=
ization<br>
(#936) is also ACK&#39;d, but it might be good to wait until later in the m=
erge<br>
window considering its low impact and high potential for change as the BIP<=
br>
gets closer to Accepted status.<br></blockquote><div><br></div><div>Agreed.=
</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 =
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
any sort of high-volume bitcoind usage (such as solo mining). Some other<br=
>
optimizations by Joel such as the optimized ToHex function (#562) and<br></=
blockquote><div><br></div><div>See my comments there; I&#39;m all for optim=
izing the ToHex function, but I prefer that he optimizes the current ToHex =
function not add yet another one with an incompatible interface.</div>
<div><br></div><div>(we have the same problem with Error/Debug/&quot;Log to=
 console&quot; functions, too many of them and sometimes it&#39;s unclear w=
hat the difference is)</div><div>=C2=A0</div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
>
Scott has a pull request for Bitcoin-Qt to behave more like other close-to-=
<br>
systray applications by toggling the hide/show action (#855). He&#39;s also=
<br>
contributed a patch to show miners&#39; immature balances on the overview s=
creen<br>
(#837; it leaves only a blank space for non-miners). Nils, on the other han=
d,<br>
has been working with a UI designer to totally remodel Bitcoin-Qt.<br></blo=
ckquote><div><br></div><div>I also have some UI code changes ready, for exa=
mple one to use notification from the bitcoin core when the address book/tr=
ansactions changed, instead of a timer. Will submit pull requests soon.</di=
v>
<div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">Coderrr has rebased his Coin =
Control features (#415) to the latest version.<br>
These seem to be popular, so should probably be merged as soon as it&#39;s =
had=C2=A0proper review.<br></blockquote><div><br></div><div>Agreed. It is v=
ery popular and should certainly be merged. And it has seen quite some test=
ing already. Though this will take some time to review, as it is quite a la=
rge change.</div>
<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex">Finally, I don&#39;t know t=
he status of Pieter&#39;s IPv6 support, but I hope it will<br>
be ready for 0.7. Right now all I see submitted for this is support for<br>
multiple local IPs (#829) though.<br><br></blockquote><div><br></div><div>I=
Pv6 support would be nice, but I don&#39;t think a milestone of 0.7 is real=
istic. Such a change to the network code will require extensive testing. Wh=
o has access to IPv6 and can help testing?=C2=A0</div>
<div>=C2=A0</div><div>Wladimir</div><div><br></div></div>

--20cf3056397120b66104bc854d73--