MIME-Version: 1.0
References: <d43c6082-1b2c-c95b-5144-99ad0021ea6c@mattcorallo.com>
	<CAAS2fgRF-MhOvpFY6c_qAPzNMo3GQ28RExdSbOV6Q6Oy2iWn1A@mail.gmail.com>
	<22d375c7-a032-8691-98dc-0e6ee87a4b08@mattcorallo.com>
	<CAAS2fgR3QRHeHEjjOS1ckEkL-h7=Na56G12hYW9Bmy9WEMduvg@mail.gmail.com>
	<CADZtCShLmH_k-UssNWahUNHgHvWQQ1y638LwaOfnJEipwjbiYg@mail.gmail.com>
	<CAAS2fgQLCN_cuZ-3QPjCLfYOtHfEk=SenTn5=y9LfGzJxLPR3Q@mail.gmail.com>
	<CADZtCSjYr6VMBVQ=rx44SgRWcFSXhVXUZJB=rHMh4X78Z2eY1A@mail.gmail.com>
	<CAO3Pvs9K3n=OzVQ06XGQvzNC+Aqp9S60kWM9VRPA8hWTJ3u9BQ@mail.gmail.com>
	<c23a5346-9f99-44f0-abbf-d7e7979bf1d8@gmail.com>
	<CAO3Pvs_MA4TtgCCu1NgCBjK2bZRN+rKnGQJN6m4yTrViBXRiPA@mail.gmail.com>
	<CAD3i26BibcaMdbQv-j+Egz_1y0GuhzepBp5ATNpj=Qv8hi1TVA@mail.gmail.com>
	<CADZtCShAYpbN=4qNoX5c8yd1j08+mEZzG8gZwcHrj2suY0mb9w@mail.gmail.com>
	<CADZtCShYnM3A949H18V2+BArA-K9J+cDkd=rX8xRn0+0js5CwA@mail.gmail.com>
	<CAAS2fgTXS5Tains7dfe_Rc9JxR6M=NuFW9UtieRELm+6N2uNog@mail.gmail.com>
	<CAFfwr8F+ghYb2HYEgC7Lh7Z-ytNE7EABr6cxiVXYhWLk-TPO7A@mail.gmail.com>
	<CADZtCShDzPK_jqeOrK4XBoB2uriU9c9T8Dm7By-8ew3XOoAeQg@mail.gmail.com>
	<7E4FA664-BBAF-421F-8C37-D7CE3AA5310A@gmail.com>
	<F87D7069-0FDC-4572-B02B-398A2A455935@gmail.com>
	<CAAS2fgT716PiP0ucoASxryM9y+s9H2z06Z0ToaP1xT3BozAtNw@mail.gmail.com>
	<CADZtCSguto2z6Z9CykymxnCokqo1G=sW0Ov0ht+KcD+KMnYyow@mail.gmail.com>
In-Reply-To: <CADZtCSguto2z6Z9CykymxnCokqo1G=sW0Ov0ht+KcD+KMnYyow@mail.gmail.com>
From: Olaoluwa Osuntokun <laolu32@gmail.com>
Date: Mon, 28 May 2018 21:01:35 -0700
Message-ID: <CAO3Pvs-YDzfRqmyJ85wTH0ciccjCvkm5stGyP_tVGGna=PMv3A@mail.gmail.com>
To: Jim Posen <jim.posen@gmail.com>, 
	Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary="00000000000015246c056d504b19"
Subject: Re: [bitcoin-dev] BIP 158 Flexibility and Filter Size
Precedence: list

--00000000000015246c056d504b19
Content-Type: text/plain; charset="UTF-8"

> The additional benefit of the input script/outpoint filter is to watch for
> unexpected spends (coins getting stolen or spent from another wallet) or
> transactions without a unique change or output address. I think this is a
> reasonable implementation, and it would be nice to be able to download
that
> filter without any input elements.

As someone who's implemented a complete integration of the filtering
technique into an existing wallet, and a higher application I disagree.
There's not much gain to be had in splitting up the filters: it'll result in
additional round trips (to fetch these distinct filter) during normal
operation, complicate routine seed rescanning logic, and also is detrimental
to privacy if one is fetching blocks from the same peer as they've
downloaded the filters from.

However, I'm now convinced that the savings had by including the prev output
script (addr re-use and outputs spent in the same block as they're created)
outweigh the additional booking keeping required in an implementation (when
extracting the precise tx that matched) compared to using regular outpoint
as we do currently. Combined with the recently proposed re-parametrization
of the gcs parameters[1], the filter size should shrink by quite a bit!

I'm very happy with the review the BIPs has been receiving as of late. It
would've been nice to have this 1+ year ago when the draft was initially
proposed, but better late that never!

Based on this thread, [1], and discussions on various IRC channels, I plan
to make the following modifications to the BIP:

  1. use P=2^19 and M=784931 as gcs parameters, and also bind these to the
     filter instance, so future filter types may use distinct parameters
  2. use the prev output script rather than the prev input script in the
     regular filter
  3. remove the txid from the regular filter(as with some extra book-keeping
     the output script is enough)
  4. do away with the extended filter all together, as our original use case
     for it has been nerfed as the filter size grew too large when doing
     recursive parsing. instead we watch for the outpoint being spent and
     extract the pre-image from it if it matches now

The resulting changes should slash the size of the filters, yet still ensure
that they're useful enough for our target use case.

[1]:
https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-May/016029.html

-- Laolu

--00000000000015246c056d504b19
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>&gt; The additional benefit of the input script/outpo=
int filter is to watch for<br></div><div><div>&gt; unexpected spends (coins=
 getting stolen or spent from another wallet) or</div><div>&gt; transaction=
s without a unique change or output address. I think this is a</div><div>&g=
t; reasonable implementation, and it would be nice to be able to download t=
hat</div><div>&gt; filter without any input elements.=C2=A0</div><div><br><=
/div><div>As someone who&#39;s implemented a complete integration of the fi=
ltering</div><div>technique into an existing wallet, and a higher applicati=
on I disagree.</div><div>There&#39;s not much gain to be had in splitting u=
p the filters: it&#39;ll result in</div><div>additional round trips (to fet=
ch these distinct filter) during normal</div><div>operation, complicate rou=
tine seed rescanning logic, and also is detrimental</div><div>to privacy if=
 one is fetching blocks from the same peer as they&#39;ve</div><div>downloa=
ded the filters from.</div><div><br></div><div>However, I&#39;m now convinc=
ed that the savings had by including the prev output</div><div>script (addr=
 re-use and outputs spent in the same block as they&#39;re created)</div><d=
iv>outweigh the additional booking keeping required in an implementation (w=
hen</div><div>extracting the precise tx that matched) compared to using reg=
ular outpoint</div><div>as we do currently. Combined with the recently prop=
osed re-parametrization</div><div>of the gcs parameters[1], the filter size=
 should shrink by quite a bit!</div><div><br></div><div>I&#39;m very happy =
with the review the BIPs has been receiving as of late. It</div><div>would&=
#39;ve been nice to have this 1+ year ago when the draft was initially</div=
><div>proposed, but better late that never!</div><div><br></div><div>Based =
on this thread, [1], and discussions on various IRC channels, I plan</div><=
div>to make the following modifications to the BIP:</div><div><br></div><di=
v>=C2=A0 1. use P=3D2^19 and M=3D784931 as gcs parameters, and also bind th=
ese to the</div><div>=C2=A0 =C2=A0 =C2=A0filter instance, so future filter =
types may use distinct parameters</div><div>=C2=A0 2. use the prev output s=
cript rather than the prev input script in the</div><div>=C2=A0 =C2=A0 =C2=
=A0regular filter</div><div>=C2=A0 3. remove the txid from the regular filt=
er(as with some extra book-keeping</div><div>=C2=A0 =C2=A0 =C2=A0the output=
 script is enough)=C2=A0</div><div>=C2=A0 4. do away with the extended filt=
er all together, as our original use case</div><div>=C2=A0 =C2=A0 =C2=A0for=
 it has been nerfed as the filter size grew too large when doing</div><div>=
=C2=A0 =C2=A0 =C2=A0recursive parsing. instead we watch for the outpoint be=
ing spent and</div><div>=C2=A0 =C2=A0 =C2=A0extract the pre-image from it i=
f it matches now</div><div><br></div><div>The resulting changes should slas=
h the size of the filters, yet still ensure</div><div>that they&#39;re usef=
ul enough for our target use case.</div><div><br></div><div>[1]: <a href=3D=
"https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-May/016029.ht=
ml">https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-May/016029=
.html</a></div><div><br></div><div>-- Laolu</div></div></div>

--00000000000015246c056d504b19--