Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WnDeR-0002HJ-4u for bitcoin-development@lists.sourceforge.net; Wed, 21 May 2014 21:02:15 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; envelope-from=gmaxwell@gmail.com; helo=mail-lb0-f180.google.com; Received: from mail-lb0-f180.google.com ([209.85.217.180]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1WnDeQ-00057u-BF for bitcoin-development@lists.sourceforge.net; Wed, 21 May 2014 21:02:15 +0000 Received: by mail-lb0-f180.google.com with SMTP id p9so1987159lbv.39 for ; Wed, 21 May 2014 14:02:07 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.76.66 with SMTP id i2mr37702876lbw.37.1400706127539; Wed, 21 May 2014 14:02:07 -0700 (PDT) Received: by 10.112.89.68 with HTTP; Wed, 21 May 2014 14:02:07 -0700 (PDT) In-Reply-To: <537D0CE1.3000608@monetize.io> References: <7B48B9D4-5FB0-42CA-A462-C20D3F345A9A@beams.io> <537D0CE1.3000608@monetize.io> Date: Wed, 21 May 2014 14:02:07 -0700 Message-ID: From: Gregory Maxwell To: Mark Friedenbach Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gmaxwell[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1WnDeQ-00057u-BF Cc: Bitcoin Development Subject: Re: [Bitcoin-development] PSA: Please sign your git commits X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 May 2014 21:02:15 -0000 On Wed, May 21, 2014 at 1:30 PM, Mark Friedenbach wrote: > Honest question: what would signed commits do to help us here anyway? > What's the problem being solved? > > Unfortunately git places signatures in the history itself, so it's not > like we could use easily use signatures to indicate acceptance after > code review, like we could if we were using monotone for example. Git > just wasn't designed for a commit-signing workflow. Just makes it easier to sort out things like your git account (or the git site) being compromised and used to submit commits.