MIME-Version: 1.0
References: <ZNW9BenWIhgX95zl@alke>
In-Reply-To: <ZNW9BenWIhgX95zl@alke>
From: Pavol Rusnak <stick@satoshilabs.com>
Date: Fri, 11 Aug 2023 12:06:22 +0200
Message-ID: <CAF90AvnE+rNnbrS3Y_A7xfnAhvB+0xUnLGFv4X6pFssjocBFtw@mail.gmail.com>
To: Tobin Harding <me@tobin.cc>, 
 Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary="0000000000008d28420602a2df83"
Subject: Re: [bitcoin-dev] segwit naming ambiguity
Precedence: list

--0000000000008d28420602a2df83
Content-Type: text/plain; charset="UTF-8"

Here's my idea for a clean API:

1. `is_segwit()` returns true for a p2tr output

2. a function `segwit_version()` which returns an int according to segwit
version used

3. helper functions like `is_p2wpkh()`, `is_p2tr()`, `is_p2wsh()` for all
script types which all return a bool


On Fri, 11 Aug 2023 at 08:41, Tobin Harding via bitcoin-dev <
bitcoin-dev@lists.linuxfoundation.org> wrote:

> Question for OG bitcoin API designers please.
>
> If you were to see the following function
>
>     `is_segwit()`
>
> would you assume it returns `true` or `false` for a p2tr transaction?
>
>
> Currently we (rust-bitcoin) are being liberal with the use of `v0` but
> its a pretty ugly. Is there an official, or widely used, name for segwit
> v0?
>
>
> Thanks,
> Tobin.
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>


-- 
Best Regards / S pozdravom,

Pavol "Stick" Rusnak
Co-Founder, SatoshiLabs

--0000000000008d28420602a2df83
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Here&#39;s my idea for a clean API:</div><div><br></d=
iv>1. `is_segwit()` returns true for a p2tr output<div><br></div><div>2. a =
function `segwit_version()` which returns an int according to segwit versio=
n used</div><div><br></div><div>3. helper functions like `is_p2wpkh()`, `is=
_p2tr()`, `is_p2wsh()` for all script types which all return a bool</div><d=
iv>=C2=A0</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">On Fri, 11 Aug 2023 at 08:41, Tobin Harding via bitcoin-dev=
 &lt;<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@l=
ists.linuxfoundation.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">Question for OG bitcoin API designers please.<br>
<br>
If you were to see the following function<br>
<br>
=C2=A0 =C2=A0 `is_segwit()`<br>
<br>
would you assume it returns `true` or `false` for a p2tr transaction?<br>
<br>
<br>
Currently we (rust-bitcoin) are being liberal with the use of `v0` but<br>
its a pretty ugly. Is there an official, or widely used, name for segwit v0=
?<br>
<br>
<br>
Thanks,<br>
Tobin.<br>
_______________________________________________<br>
bitcoin-dev mailing list<br>
<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" target=3D"_blank">=
bitcoin-dev@lists.linuxfoundation.org</a><br>
<a href=3D"https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev" =
rel=3D"noreferrer" target=3D"_blank">https://lists.linuxfoundation.org/mail=
man/listinfo/bitcoin-dev</a><br>
</blockquote></div><br clear=3D"all"><div><br></div><span class=3D"gmail_si=
gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d=
iv dir=3D"ltr"><div><div dir=3D"ltr"><div></div><div>Best Regards / S pozdr=
avom,</div><div><br></div><div>Pavol &quot;Stick&quot; Rusnak</div><div>Co-=
Founder, SatoshiLabs</div></div></div></div></div>

--0000000000008d28420602a2df83--